Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Persistence Matrix] Make options, in particular column types, more flexible #1167

Open
hschreiber opened this issue Jan 27, 2025 · 0 comments

Comments

@hschreiber
Copy link
Collaborator

hschreiber commented Jan 27, 2025

Not "easy": in my opinion, the original issue is that using an `enum` makes the design not extensible (a user cannot provide their own column type). If you changed the design enough for it to be extensible, then there would be no limitation on parameterizing the column types you provide.
(IIRC, Boost.Graph has a similar limitation with a hard-coded list of possible containers for some data structures)
Without going all the way to an extensible design, using tag classes instead of an enum (i.e. empty classes that are only used with `is_same<T,vector_column_tag>` or similar) might not require huge changes and could accommodate `small_vector_tag<8>`.

Originally posted by @mglisse in #1154 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant