Made the requested changes

Author: Moasib-Arif

dpytools/slack/slack.py

@@ -1,25 +1,31 @@
-import os
 import logging
 from dpytools.http_clients.base import BaseHttpClient
 
 class SlackNotifier:
 
-    def __init__(self):
-        self.webhook_url = os.getenv("SLACK_WEBHOOK_URL")
-        if not self.webhook_url:
-            raise ValueError('SLACK_WEBHOOK_URL is not set')
+    def __init__(self, webhook_url):
+        if not webhook_url:
+            raise ValueError('webhook_url is not set')
+        self.webhook_url = webhook_url
         self.http_client = BaseHttpClient()
-        self.validate_webhook_url()
 
-    def validate_webhook_url(self):
-        response = self.http_client.get(self.webhook_url)
-        if response.status_code != 200:
-            logging.error(f'Invalid SLACK_WEBHOOK_URL: {response.status_code}')
-            raise ValueError('Invalid SLACK_WEBHOOK_URL')
+    def notify(self, msg_dict: dict):
+        """
+        Send a message to the Slack webhook.
 
-    def notify(self, msg: dict):
+        The msg_dict parameter should be a dictionary that matches the
+        structure documented at https://api.slack.com/messaging/webhooks
+        """
         try:
-            response = self.http_client.post(self.webhook_url, json=msg)
+            response = self.http_client.post(self.webhook_url, json=msg_dict)
             response.raise_for_status()
         except Exception as e:
             logging.error(f'Failed to send notification: {e}')
+
+    def msg_str(self, msg: str):
+        """
+        Send a string message to the Slack webhook.
+
+        The msg parameter is wrapped into a dictionary before being sent.
+        """
+        self.notify({'text': msg})

tests/test_slack.py

@@ -4,48 +4,32 @@
 from dpytools.http_clients.base import BaseHttpClient
 from dpytools.slack.slack import SlackNotifier
 
-@patch('os.getenv')
-@patch.object(BaseHttpClient, 'get')
-def test_validate_webhook_url(mock_get, mock_getenv):
-    """
-    Test that the validate_webhook_url method raises an exception for invalid URLs
-    """
-    mock_getenv.return_value = 'http://example.com'
-    mock_response = MagicMock(Response)
-    mock_response.status_code = 404
-    mock_get.return_value = mock_response
-
-    with pytest.raises(ValueError):
-        notifier = SlackNotifier()
-
-@patch('os.getenv')
-@patch.object(BaseHttpClient, 'get')
-def test_validate_webhook_url_success(mock_get, mock_getenv):
+@patch.object(BaseHttpClient, 'post')
+def test_notify(mock_post):
     """
-    Test that the validate_webhook_url method does not raise an exception for valid URLs
+    Test that the notify method sends a POST request
     """
-    mock_getenv.return_value = 'http://example.com'
+    webhook_url = 'http://example.com'
     mock_response = MagicMock(Response)
     mock_response.status_code = 200
-    mock_get.return_value = mock_response
+    mock_post.return_value = mock_response
+
+    notifier = SlackNotifier(webhook_url)
+    notifier.notify({'text': 'Test message'})
 
-    try:
-        notifier = SlackNotifier()
-    except ValueError:
-        pytest.fail("Unexpected ValueError ..")
+    mock_post.assert_called_once_with(webhook_url, json={'text': 'Test message'})
 
-@patch('os.getenv')
 @patch.object(BaseHttpClient, 'post')
-def test_notify(mock_post, mock_getenv):
+def test_msg_str(mock_post):
     """
-    Test that the notify method sends a POST request
+    Test that the msg_str method sends a POST request with a string message
     """
-    mock_getenv.return_value = 'http://example.com'
+    webhook_url = 'http://example.com'
     mock_response = MagicMock(Response)
     mock_response.status_code = 200
     mock_post.return_value = mock_response
 
-    notifier = SlackNotifier()
-    notifier.notify({'text': 'Test message'})
+    notifier = SlackNotifier(webhook_url)
+    notifier.msg_str('Test message')
 
-    mock_post.assert_called_once_with('http://example.com', json={'text': 'Test message'})
+    mock_post.assert_called_once_with(webhook_url, json={'text': 'Test message'})