Revert Hotfixes - Reenable Prod Backups and Remove Logging (#4591)

* Revert "Hotfix -- staffuser logging (#4585)"

This reverts commit 12364b4.

* Revert "Update create_staffusers.py (#4584)"

This reverts commit 116e65d.

* Revert "Temporarily limit backups to prod (#4583)"

This reverts commit 448c3f9.

* Apply suggestions from code review

---------

Co-authored-by: Dan Swick <[email protected]>

Author: jperson1

.github/workflows/deploy-application.yml

@@ -70,7 +70,6 @@ jobs:
           cf_command: update-user-provided-service fac-key-service -p '"{\"SAM_API_KEY\":\"${{ secrets.SAM_API_KEY }}\", \"DJANGO_SECRET_LOGIN_KEY\":\"${{ secrets.DJANGO_SECRET_LOGIN_KEY }}\", \"LOGIN_CLIENT_ID\":\"${{ secrets.LOGIN_CLIENT_ID }}\", \"SECRET_KEY\":\"${{ secrets.SECRET_KEY}}\"}"'
 
       - name: Backup the database
-        if: startsWith(github.ref, 'refs/tags/v1.')
         uses: cloud-gov/cg-cli-tools@main
         with:
           cf_username: ${{ secrets.CF_USERNAME }}

backend/users/management/commands/create_staffusers.py

@@ -1,4 +1,3 @@
-# flake8: noqa
 from django.conf import settings
 from django.contrib.auth import get_user_model
 from django.contrib.auth.models import Group, Permission
@@ -17,9 +16,6 @@ class Command(BaseCommand):
 
     def handle(self, *args, **kwargs):
         """Create a group with readonly permissions."""
-        logger.info(f"Permission dump ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~")
-        logger.info(Permission.objects.all().values())
-
         group_readonly, created = Group.objects.get_or_create(name="Read-only")
         readonly_codenames = [
             "view_access",
@@ -44,10 +40,7 @@ def handle(self, *args, **kwargs):
         ]
         group_readonly.permissions.clear()
         for code in readonly_codenames:
-            try:
-                group_readonly.permissions.add(Permission.objects.get(codename=code))
-            except Exception as e:
-                logger.error(f"1. Failed to get ({code}) -- {e}")
+            group_readonly.permissions.add(Permission.objects.get(codename=code))
         group_readonly.save()
 
         """Create a group with helpdesk permissions."""
@@ -65,10 +58,7 @@ def handle(self, *args, **kwargs):
         ]
         group_helpdesk.permissions.clear()
         for code in helpdesk_codenames:
-            try:
-                group_helpdesk.permissions.add(Permission.objects.get(codename=code))
-            except Exception as e:
-                logger.error(f"2. Failed to get ({code}) -- {e}")
+            group_helpdesk.permissions.add(Permission.objects.get(codename=code))
         group_helpdesk.save()
 
         # read in staffusers JSON.