Skip to content

fix(orderbook): reduce invalid states and improve sync reliability #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shamardy wants to merge 16 commits into
base: dev
Choose a base branch
from
Draft

fix(orderbook): reduce invalid states and improve sync reliability #2626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a73a714
Revert "Revert "fix(ordermatch): ignore loop-back; clear on null root…
shamardy Oct 6, 2025
e3ad3ca
Revert "Revert "fix(orderbook): validate roots before commit (#2605)""
shamardy Oct 6, 2025
ec7ebbf
deps: add libp2p-allow-block-list
shamardy Sep 12, 2025
2a33a4f
p2p: integrate allow/block list; add temp-ban/unban + expiry
shamardy Sep 12, 2025
e795c0c
p2p: temp-ban on orderbook SyncFailure (1h)
shamardy Sep 12, 2025
1ea5481
lp_network: add 120s per‑peer grace before temp‑banning on orderbook …
shamardy Sep 13, 2025
0be2785
fix(ordermatch): safer sync + role/cause-aware bans; tighten keep-alive
shamardy Sep 15, 2025
b21b778
p2p: track ban reasons; auto-unban connectivity to restore mesh
shamardy Sep 16, 2025
08345d4
fix(p2p): use libp2p validation‑based forwarding
shamardy Sep 17, 2025
a69f66d
add a todo note about banning for other reasons like invalid topics a…
shamardy Sep 17, 2025
6b9db96
add StaleKeepAlive.delay field to debug the logs for how late are the…
shamardy Sep 17, 2025
dac2e3e
docs(ordermatch,gossipsub): KA duplicates investigation; TODOs only
shamardy Sep 20, 2025
0be254b
feat(ordermatch,p2p): add optional `expected_roots` to `SyncPubkeyOrd…
shamardy Sep 24, 2025
51308fd
feat(ordermatch,p2p): send `expected_roots` in `SyncPubkeyOrderbookSt…
shamardy Sep 25, 2025
bb2d6f7
feat(ordermatch): target exact to-root via from_history with temp Ful…
shamardy Sep 25, 2025
f7baf4f
docs(ordermatch): add TODOs v2 sync tests
shamardy Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ jobs:
- name: Test
run: |
wget -O - https://raw.githubusercontent.com/KomodoPlatform/komodo/635112d590618165a152dfa0f31e95a9be39a8f6/zcutil/fetch-params-alt.sh | bash
cargo test --test 'mm2_tests_main' --no-fail-fast
cargo test --test 'mm2_tests_main' --features for-tests --no-fail-fast

mac-x86-64-kdf-integration:
timeout-minutes: 90
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
- name: Test
run: |
wget -O - https://raw.githubusercontent.com/KomodoPlatform/komodo/635112d590618165a152dfa0f31e95a9be39a8f6/zcutil/fetch-params-alt.sh | bash
cargo test --test 'mm2_tests_main' --no-fail-fast
cargo test --test 'mm2_tests_main' --features for-tests --no-fail-fast

win-x86-64-kdf-integration:
timeout-minutes: 90
Expand Down Expand Up @@ -191,7 +191,7 @@ jobs:
- name: Test
run: |
Invoke-WebRequest -Uri https://raw.githubusercontent.com/KomodoPlatform/komodo/635112d590618165a152dfa0f31e95a9be39a8f6/zcutil/fetch-params-alt.bat -OutFile \cmd.bat && \cmd.bat
cargo test --test 'mm2_tests_main' --no-fail-fast
cargo test --test 'mm2_tests_main' --features for-tests --no-fail-fast

docker-tests:
timeout-minutes: 90
Expand Down
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ jsonrpc-core = "18.0.0"
lazy_static = "1.4"
libc = "0.2"
libp2p = { git = "https://github.com/KomodoPlatform/rust-libp2p.git", tag = "k-0.52.12", default-features = false }
libp2p-allow-block-list = { git = "https://github.com/KomodoPlatform/rust-libp2p.git", tag = "k-0.52.12" }
lightning = "0.0.113"
lightning-background-processor = "0.0.113"
lightning-invoice = { version = "0.21.0", features = ["serde"] }
Expand Down
19 changes: 17 additions & 2 deletions mm2src/mm2_main/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ custom-swap-locktime = [] # only for testing purposes, should never be activated
native = [] # Deprecated
track-ctx-pointer = ["common/track-ctx-pointer"]
zhtlc-native-tests = ["coins/zhtlc-native-tests"]
run-docker-tests = ["coins/run-docker-tests"]
run-docker-tests = ["for-tests", "coins/run-docker-tests"]
default = []
trezor-udp = ["crypto/trezor-udp"] # use for tests to connect to trezor emulator over udp
run-device-tests = []
Expand All @@ -29,7 +29,12 @@ new-db-arch = ["mm2_core/new-db-arch"] # A temporary feature to integrate the ne
# Temporary feature for implementing IBC wrap/unwrap mechanism and will be removed
# once we consider it as stable.
ibc-routing-for-swaps = []
for-tests = []
for-tests = [
"coins/for-tests",
"coins_activation/for-tests",
"common/for-tests",
"trading_api/for-tests"
]
enable-solana = ["coins/enable-solana", "coins_activation/enable-solana"]

[dependencies]
Expand Down Expand Up @@ -157,3 +162,13 @@ gstuff.workspace = true
prost-build = { version = "0.12", default-features = false }
regex.workspace = true

[[test]]
name = "docker_tests_main"
path = "tests/docker_tests_main.rs"
required-features = ["run-docker-tests"]

[[test]]
name = "mm2_tests_main"
path = "tests/mm2_tests_main.rs"
required-features = ["for-tests"]

Loading
Loading