Skip to content

Crash Report: Blazin' crashin' when hitting F5 (Hot Reload) #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
Starexify opened this issue May 4, 2025 · 8 comments · May be fixed by #5065
Open
3 tasks done

Crash Report: Blazin' crashin' when hitting F5 (Hot Reload) #4990

Starexify opened this issue May 4, 2025 · 8 comments · May be fixed by #5065
Labels
status: resolved internally Completed development and will be released some time in the future. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Milestone

Comments

@Starexify
Copy link

Starexify commented May 4, 2025

Issue Checklist

  • I have read the Contributing Guide
  • I have checked the Issues/Discussions pages to see if my issue has already been reported
  • I have properly titled my issue

Platform

Itch.io (Downloadable Build) - Windows

Version

0.6.4

Description

When I try to hit F5 (hot reload) during Blazin it's crashin with:
1.
Image
2.
Image
3.
Image

Steps to Reproduce

  1. Open the game
  2. Choose Pico and play Blazin'
  3. Refresh during Blazin' and be welcomed by the Crashin`

Crash logs

crash-2025-05-04-17-30-43.log

@Starexify Starexify added status: pending triage Awaiting review. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression labels May 4, 2025
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented May 4, 2025

Interestingly another issue that would be solved by my null-safe PlayState PR. Well, at least partially so.

2025-05-04.13-06-14.mp4

@VioletSnowLeopard
Copy link
Contributor

The line where the game crashed in PlayState.hx is this:
var discordRPCDifficulty = PlayState.instance.currentDifficulty.replace('-', ' ').toTitleCase();

It's interesting that this causes the game to crash when reloading during Blazin', but not on other songs.

@VioletSnowLeopard
Copy link
Contributor

Interestingly another issue that would be solved by my null-safe PlayState PR. Well, at least partially so.

I think the song scripts might need to be null-safe to prevent the Polymod Script Exceptions from appearing.

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented May 4, 2025

Interestingly another issue that would be solved by my null-safe PlayState PR. Well, at least partially so.

I think the song scripts might need to be null-safe to prevent the Polymod Script Exceptions from appearing.

Indeed, adding a null check (?) to PlayState.instance at lines 64 and 78 prevents the error messages.

@Lasercar
Copy link
Contributor

Lasercar commented May 4, 2025

Interestingly another issue that would be solved by my null-safe PlayState PR. Well, at least partially so.
2025-05-04.13-06-14.mp4

@:nullSafety

W

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented May 4, 2025

I think what introduced this bug though was commit 3e0dbe2 which causes reloading on PlayState to run performCleanup. You can see that among other things it will set PlayState.instance to null, which would explain the Polymod Exceptions

Image

@NotHyper-474
Copy link
Contributor

NotHyper-474 commented May 4, 2025

And as I expected, simply doing this causes the errors to not happen anymore. I suppose it also messes with the Discord line because it too tries to access instance when it's null.
Image

@AbnormalPoof AbnormalPoof added status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. and removed status: pending triage Awaiting review. labels May 7, 2025
@AbnormalPoof
Copy link
Collaborator

This can occur on any song.

@AbnormalPoof AbnormalPoof added status: pending pull request Dependent on a pull request that is currently awaiting review. and removed status: bug reproduced Involves a bug which can be reliably reproduced by reviewers. labels May 11, 2025
@Hundrec Hundrec added this to the 0.7.0 milestone May 29, 2025
@Hundrec Hundrec added status: resolved internally Completed development and will be released some time in the future. and removed status: pending pull request Dependent on a pull request that is currently awaiting review. labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved internally Completed development and will be released some time in the future. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants