Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on GTF #369

Closed
adlerjohn opened this issue Jun 24, 2022 · 1 comment
Closed

Follow-up on GTF #369

adlerjohn opened this issue Jun 24, 2022 · 1 comment
Labels
comp:FVM Component: FuelVM question Further information is requested

Comments

@adlerjohn
Copy link
Contributor

Should we leave more spacing between script tx fields and create tx fields? I noticed you left plenty of space between the input, output and witness values, but script tx doesn't have much room to grow.

Also is there a way we could assign these imm values to make compatibility checking more efficient using bitmasks?

I.e. if script tx fields fit within a bitmask of 0x00ff and create tx fields fit within a bitmask of 0xff00, then it should be easier to specify which fields are not available.

Right now this seems a little fuzzy by just saying:

Panic If:
The input or output type does not match (OutputChange and OutputVariable count as OutputCoin)

We should be able to specify exactly what is valid or invalid.

Originally posted by @Voxelot in #353 (comment)

@adlerjohn adlerjohn added the comp:FVM Component: FuelVM label Jun 24, 2022
@adlerjohn adlerjohn added the question Further information is requested label Jun 24, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jun 24, 2022
@sdankel sdankel removed this from Fuel Network Sep 5, 2023
@xgreenx
Copy link
Contributor

xgreenx commented Jan 24, 2024

Done during #514

@xgreenx xgreenx closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:FVM Component: FuelVM question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants