Fix CI checks for Ubuntu 24.04 (#117)

aggarg · web-flow · commit b9b343db5988 · 2025-01-24T15:12:22.000+05:30
ubuntu-latest is now Ubuntu 24.04 which requires some CI-CD fixes.

Signed-off-by: Gaurav Aggarwal &lt;aggarg@amazon.com&gt;
diff --git a/.github/workflows/formattingTests.yml b/.github/workflows/formattingTests.yml
@@ -316,7 +316,6 @@ jobs:
       uses: ./clang-formatting
       with:
         path: clang-formatting/goodFiles
-        exclude-dirs: ",,,"
         exclude-files: "errorFileInDirectory.h, formatErrorTest.h, errorFileInDirectory.c, formatErrorTest.c"
 
     - name: Remove Error Files at Top Directory
diff --git a/.github/workflows/pr_checks.yml b/.github/workflows/pr_checks.yml
@@ -58,8 +58,7 @@ jobs:
               run-spelling-check: true,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*3rdparty\*"',
+              build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='-Wall -Wextra -Werror',
             },
             {
               repository: coreHTTP,
@@ -69,8 +68,8 @@ jobs:
               run-spelling-check: true,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*3rdparty\*"',
+              build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='-Wall -Wextra -DNDEBUG',
+              coverage-skips: "*3rdparty*",
             },
             {
               repository: coreJSON,
@@ -80,8 +79,7 @@ jobs:
               run-spelling-check: true,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON  -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*source\*"',
+              build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON  -DCMAKE_C_FLAGS='-Wall -Wextra -Werror',
             },
             {
               repository: coreMQTT,
@@ -92,7 +90,6 @@ jobs:
               run-complexity: true,
               run-doxygen: true,
               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG -DLIBRARY_LOG_LEVEL=LOG_DEBUG',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
             },
             {
               repository: corePKCS11,
@@ -102,8 +99,7 @@ jobs:
               run-spelling-check: false,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DCMAKE_BUILD_TYPE=Debug -DSYSTEM_TESTS=0 -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+              build-flags: -DCMAKE_BUILD_TYPE=Debug -DSYSTEM_TESTS=0 -DCMAKE_C_FLAGS='-Wall -Wextra -DNDEBUG',
               branch-coverage: 90,
             },
             {
@@ -114,8 +110,7 @@ jobs:
               run-spelling-check: true,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG -Wno-error=pedantic -Wno-variadic-macros -DLOGGING_LEVEL_DEBUG=1',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+              build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='-Wall -Wextra -Werror -DNDEBUG -Wno-error=pedantic -Wno-variadic-macros -DLOGGING_LEVEL_DEBUG=1',
             },
             {
               repository: FreeRTOS-Cellular-Interface,
@@ -125,8 +120,7 @@ jobs:
               run-spelling-check: true,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+              build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='-Wall -Wextra -Werror -DNDEBUG',
             },
             {
               repository: Device-Defender-for-AWS-IoT-embedded-sdk,
@@ -136,8 +130,7 @@ jobs:
               run-spelling-check: true,
               run-complexity: true,
               run-doxygen: true,
-              build-flags: -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
-              coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+              build-flags: -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='-Wall -Wextra -Werror -DNDEBUG',
             },
             {
                repository: Device-Shadow-for-AWS-IoT-embedded-sdk,
@@ -146,8 +139,7 @@ jobs:
                run-link-verifier: true,
                run-spelling-check: true,
                run-complexity: true,
-               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
-               coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='-Wall -Wextra -Werror -DNDEBUG',
             },
             {
                repository: Fleet-Provisioning-for-AWS-IoT-embedded-sdk,
@@ -157,8 +149,7 @@ jobs:
                run-spelling-check: true,
                run-complexity: true,
                run-doxygen: true,
-               build-flags:  -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG',
-               coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+               build-flags:  -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='-Wall -Wextra -Werror -DNDEBUG',
             },
             {
                repository: Jobs-for-AWS-IoT-embedded-sdk,
@@ -168,8 +159,7 @@ jobs:
                run-spelling-check: true,
                run-complexity: false,
                run-doxygen: true,
-               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror',
-               coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*" "\*source\*"',
+               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='-Wall -Wextra -Werror',
             },
             {
                repository: ota-for-AWS-IoT-embedded-sdk,
@@ -179,7 +169,7 @@ jobs:
                run-spelling-check: true,
                run-complexity: true,
                run-doxygen: true,
-               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG',
+               build-flags: -DCMAKE_BUILD_TYPE=Debug -DBUILD_CLONE_SUBMODULES=ON -DCMAKE_C_FLAGS='-Wall -Wextra -DNDEBUG',
             },
             {
                repository: SigV4-for-AWS-IoT-embedded-sdk,
@@ -188,8 +178,7 @@ jobs:
                run-complexity: true,
                run-spelling-check: true,
                run-doxygen: true,
-               build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='--coverage -Wall -Wextra -DNDEBUG -DLOGGING_LEVEL_DEBUG=1',
-               coverage-skips: '"\*test\*" "\*CMakeCCompilerId\*" "\*mocks\*"',
+               build-flags: -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_FLAGS='-Wall -Wextra -DNDEBUG -DLOGGING_LEVEL_DEBUG=1',
             },
           ]
     steps:
@@ -220,7 +209,7 @@ jobs:
         with:
           path: repo/${{ matrix.inputs.repository }}
           exclude-dirs: complexity, formatting
-          exclude-urls: https://dummy-url.com/ota.bin, https://s3.region.amazonaws.com/joe-ota
+          exclude-urls: https://dummy-url.com/ota.bin, https://s3.region.amazonaws.com/joe-ota, https://www.gnu.org/software/complexity/manual/complexity.html, https://www.u-blox.com/en/product/sara-r4-series
 
       - name: "Complexity Check: ${{ matrix.inputs.repository }}"
         if: matrix.inputs.run-complexity && ( success() || failure() )
@@ -321,9 +310,10 @@ jobs:
           else
             lcov --rc lcov_branch_coverage=1 -r build/coverage.info -o build/coverage.info
           fi
+
           echo -e "::endgroup::"
 
-          lcov --rc lcov_branch_coverage=1 --list build/coverage.info
+          lcov --rc lcov_branch_coverage=1 --summary build/coverage.info
 
       - name: Test coverage cop action ${{matrix.inputs.repository}}
         if: matrix.inputs.run-complexity && ( success() || failure() )
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -185,11 +185,10 @@ jobs:
           echo -e "::endgroup::"
 
           echo -e "::group::${{ env.bashInfo }} ${{ env.stepName }} ${{ env.bashEnd }}"
-          declare -a EXCLUDE=("\*test/\*" "\*CMakeCCompilerId\*" "\*mocks\*")
-          echo ${EXCLUDE[@]} | xargs lcov --rc lcov_branch_coverage=1 --remove build/coverage.info -o build/coverage.info
+          lcov --rc lcov_branch_coverage=1 --remove build/coverage.info -o build/coverage.info
           echo -e "::endgroup::"
 
-          lcov --rc lcov_branch_coverage=1 --list build/coverage.info
+          lcov --rc lcov_branch_coverage=1 --summary build/coverage.info
           echo -e "${{ env.bashPass }} ${{env.stepName }} ${{ env.bashEnd }}"
 
       - name: Test Coverage Cop Action
@@ -215,11 +214,11 @@ jobs:
           echo -e "::group::${{ env.bashInfo }} ${{ env.stepName }} ${{ env.bashEnd }}"
           declare -a EXCLUDE=("\*test/\*")
           set +e
-          lcov --directory build/ --base-directory build/ --initial --capture --rc lcov_branch_coverage=1 --output-file=build/base_coverage.info
+          lcov --directory build/ --base-directory build/ --initial --capture --rc lcov_branch_coverage=1 --exclude "*CMakeCCompilerId.c" --output-file=build/base_coverage.info
           lcov --base-directory build/ --directory build/ --add-tracefile build/base_coverage.info --add-tracefile build/second_coverage.info --output-file build/coverage.info --rc lcov_branch_coverage=1
           echo -e "::endgroup::"
 
-          lcov --rc lcov_branch_coverage=1 --list build/coverage.info
+          lcov --rc lcov_branch_coverage=1 --summary build/coverage.info
           set -e
           echo -e "${{ env.bashPass }} ${{env.stepName }} ${{ env.bashEnd }}"
 
@@ -288,7 +287,7 @@ jobs:
         with:
           path: ./
           exclude-dirs: complexity, formatting
-          exclude-urls: https://dummy-url.com/ota.bin, https://dummy-url.com/ota.com, https://dummy-url-three.com/ota.bin, https://github.com/FreeRTOS/A-Repo-That-Wins-You-The-Lottery
+          exclude-urls: https://dummy-url.com/ota.bin, https://dummy-url.com/ota.com, https://dummy-url-three.com/ota.bin, https://github.com/FreeRTOS/A-Repo-That-Wins-You-The-Lottery, https://www.gnu.org/software/complexity/manual/complexity.html
 
       - env:
           stepName: "Functional | Failure | Link Does Not Exist"
diff --git a/clang-formatting/action.yml b/clang-formatting/action.yml
@@ -128,11 +128,12 @@ runs:
     - name: Upload Formatting Git Patch
       if: failure() && ( steps.action-formatting-check.outcome == 'failure' )
       id: upload-formatting-patch
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: formattingChanges
         path: ${{ inputs.path }}/formattingChanges.patch
         retention-days: 7
+        overwrite: true
 
     - env:
         bashPass: \033[32;1m
diff --git a/coverage-cop/action.yml b/coverage-cop/action.yml
@@ -46,9 +46,9 @@ runs:
         # TODO: The way it grabs the line/branch coverage is a little complicated
         # I'd like to see if this can be done simpler.
         echo -e " ${{ env.bashInfo }} Received LCov Report: ${{ inputs.coverage-file }} ${{ env.bashEnd}}"
-        lcov --list --rc lcov_branch_coverage=1 ${{ inputs.coverage-file }}
-        LINE_COVERAGE=$(lcov --list ${{ inputs.coverage-file }} | tail -n 1 | cut -d '|' -f 2 | sed -n "s/\([^%]*\)%.*/\1/p")
-        BRANCH_COVERAGE=$(lcov --rc lcov_branch_coverage=1 --list ${{ inputs.coverage-file }} | tail -n 1 | cut -d '|' -f 4 | sed -n "s/\([^%]*\)%.*/\1/p")
+        lcov --summary --rc lcov_branch_coverage=1 ${{ inputs.coverage-file }}
+        LINE_COVERAGE=$(lcov --summary --rc lcov_branch_coverage=1 ${{ inputs.coverage-file }} | grep -E line.*: | cut -d ':' -f 2 | cut -d '%' -f 1 | xargs)
+        BRANCH_COVERAGE=$(lcov --summary --rc lcov_branch_coverage=1 ${{ inputs.coverage-file }} | grep -E branches.*: | cut -d ':' -f 2 | cut -d '%' -f 1 | xargs)
         RESULT=0
 
         # Check Line Coverage
@@ -80,7 +80,7 @@ runs:
     - name: Upload Failed Codecov HTML Report
       if: failure() && ( steps.action-check-line-and-branch-coverage.outcome == 'failure' )
       id: upload-codecov-report
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: CodecovHTMLReport
         path: CodecovHTMLReport.zip
diff --git a/doxygen-generation/action.yml b/doxygen-generation/action.yml
@@ -26,7 +26,7 @@ inputs:
   doxygen_dependencies:
     description: 'Space-separated dependencies for doxygen.'
     required: false
-    default: libclang-11-dev libclang-cpp11 graphviz
+    default: libclang-18-dev libclang-cpp18 graphviz
 
 runs:
   using: "composite"
diff --git a/doxygen/action.yml b/doxygen/action.yml
@@ -16,7 +16,7 @@ inputs:
   doxygen_dependencies:
     description: 'Space-separated dependencies for doxygen.'
     required: false
-    default: libclang-11-dev libclang-cpp11 graphviz
+    default: libclang-18-dev libclang-cpp18 graphviz
   generate_zip:
     description: 'Flag to indicate whether a ZIP output should be created.'
     required: false
diff --git a/formatting/action.yml b/formatting/action.yml
@@ -128,7 +128,7 @@ runs:
     - name: Upload Formatting Git Patch
       if: failure() && ( steps.action-formatting-check.outcome == 'failure' )
       id: upload-formatting-patch
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: formattingChanges
         path: ${{ inputs.path }}/formattingChanges.patch
diff --git a/link-verifier/badUrls.md b/link-verifier/badUrls.md
@@ -1,3 +1,4 @@
 https://dummy-url.com/ota.bin
 https://dummy-url.com/ota.com
 https://dummy-url-three.com/ota.bin
+https://www.gnu.org/software/complexity/manual/complexity.html
diff --git a/run_cbmc/action.yml b/run_cbmc/action.yml
@@ -94,7 +94,7 @@ runs:
         stepName: Upload zip artifact of CBMC proof results to GitHub Actions
       name: ${{ env.stepName }}
       if: ${{ env.REPO_VISIBILITY == 'public' }}
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: ${{ steps.artifact.outputs.name }}
         path: ${{ steps.artifact.outputs.name }}.zip
