Resolve MR comments

amahadaya · amahadaya · commit 3f139516bf03 · 2025-02-06T11:54:34.000-05:00
diff --git a/test/models/test_add_to_conference.py b/test/models/test_add_to_conference.py
@@ -26,7 +26,7 @@ class TestAddToConference(unittest.TestCase):
 
     def setUp(self):
         self.model = AddToConference(
-            conference_id="",
+            conference_id="TS",
         )
 
     def test_allow_call_control(self):
diff --git a/test/models/test_buy_incoming_number_request.py b/test/models/test_buy_incoming_number_request.py
@@ -26,7 +26,7 @@ class TestBuyIncomingNumberRequest(unittest.TestCase):
 
     def setUp(self):
         self.model = BuyIncomingNumberRequest(
-            phone_number="",
+            phone_number="TS",
         )
 
     def test_phone_number(self):
diff --git a/test/models/test_completion_request.py b/test/models/test_completion_request.py
@@ -26,7 +26,7 @@ class TestCompletionRequest(unittest.TestCase):
 
     def setUp(self):
         self.model = CompletionRequest(
-            query="",
+            query="TS",
         )
 
     def test_query(self):
diff --git a/test/models/test_completion_result.py b/test/models/test_completion_result.py
@@ -26,7 +26,7 @@ class TestCompletionResult(unittest.TestCase):
 
     def setUp(self):
         self.model = CompletionResult(
-            response="",
+            response="TS",
             status=CompletionResultStatus.SUCCESS,
         )
 
diff --git a/test/models/test_create_conference.py b/test/models/test_create_conference.py
@@ -26,7 +26,7 @@ class TestCreateConference(unittest.TestCase):
 
     def setUp(self):
         self.model = CreateConference(
-            action_url="",
+            action_url="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_create_web_rtc_token.py b/test/models/test_create_web_rtc_token.py
@@ -26,8 +26,8 @@ class TestCreateWebRTCToken(unittest.TestCase):
 
     def setUp(self):
         self.model = CreateWebRTCToken(
-            to="",
-            var_from="",
+            to="TS",
+            var_from="TS",
             uses=1,
         )
 
diff --git a/test/models/test_enqueue.py b/test/models/test_enqueue.py
@@ -26,9 +26,9 @@ class TestEnqueue(unittest.TestCase):
 
     def setUp(self):
         self.model = Enqueue(
-            action_url="",
-            queue_id="",
-            wait_url="",
+            action_url="TS",
+            queue_id="TS",
+            wait_url="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_filter_logs_request.py b/test/models/test_filter_logs_request.py
@@ -26,7 +26,7 @@ class TestFilterLogsRequest(unittest.TestCase):
 
     def setUp(self):
         self.model = FilterLogsRequest(
-            pql="",
+            pql="TS",
         )
 
     def test_pql(self):
diff --git a/test/models/test_get_digits.py b/test/models/test_get_digits.py
@@ -26,7 +26,7 @@ class TestGetDigits(unittest.TestCase):
 
     def setUp(self):
         self.model = GetDigits(
-            action_url="",
+            action_url="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_get_speech.py b/test/models/test_get_speech.py
@@ -26,8 +26,8 @@ class TestGetSpeech(unittest.TestCase):
 
     def setUp(self):
         self.model = GetSpeech(
-            action_url="",
-            grammar_file="",
+            action_url="TS",
+            grammar_file="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_make_call_request.py b/test/models/test_make_call_request.py
@@ -26,8 +26,8 @@ class TestMakeCallRequest(unittest.TestCase):
 
     def setUp(self):
         self.model = MakeCallRequest(
-            var_from="",
-            to="",
+            var_from="TS",
+            to="TS",
         )
 
     def test_var_from(self):
diff --git a/test/models/test_message_request.py b/test/models/test_message_request.py
@@ -26,9 +26,9 @@ class TestMessageRequest(unittest.TestCase):
 
     def setUp(self):
         self.model = MessageRequest(
-            var_from="",
-            to="",
-            text="",
+            var_from="TS",
+            to="TS",
+            text="TS",
         )
 
     def test_uri(self):
diff --git a/test/models/test_out_dial.py b/test/models/test_out_dial.py
@@ -26,10 +26,10 @@ class TestOutDial(unittest.TestCase):
 
     def setUp(self):
         self.model = OutDial(
-            action_url="",
-            call_connect_url="",
-            calling_number="",
-            destination="",
+            action_url="TS",
+            call_connect_url="TS",
+            calling_number="TS",
+            destination="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_park.py b/test/models/test_park.py
@@ -26,8 +26,8 @@ class TestPark(unittest.TestCase):
 
     def setUp(self):
         self.model = Park(
-            wait_url="",
-            action_url="",
+            wait_url="TS",
+            action_url="TS",
         )
 
     def test_wait_url(self):
diff --git a/test/models/test_play.py b/test/models/test_play.py
@@ -26,7 +26,7 @@ class TestPlay(unittest.TestCase):
 
     def setUp(self):
         self.model = Play(
-            file="",
+            file="TS",
         )
 
     def test_file(self):
diff --git a/test/models/test_play_early_media.py b/test/models/test_play_early_media.py
@@ -26,7 +26,7 @@ class TestPlayEarlyMedia(unittest.TestCase):
 
     def setUp(self):
         self.model = PlayEarlyMedia(
-            file="",
+            file="TS",
         )
 
     def test_file(self):
diff --git a/test/models/test_record_utterance.py b/test/models/test_record_utterance.py
@@ -26,7 +26,7 @@ class TestRecordUtterance(unittest.TestCase):
 
     def setUp(self):
         self.model = RecordUtterance(
-            action_url="",
+            action_url="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_redirect.py b/test/models/test_redirect.py
@@ -26,7 +26,7 @@ class TestRedirect(unittest.TestCase):
 
     def setUp(self):
         self.model = Redirect(
-            action_url="",
+            action_url="TS",
         )
 
     def test_action_url(self):
diff --git a/test/models/test_say.py b/test/models/test_say.py
@@ -26,7 +26,7 @@ class TestSay(unittest.TestCase):
 
     def setUp(self):
         self.model = Say(
-            text="",
+            text="TS",
         )
 
     def test_text(self):
diff --git a/test/models/test_send_digits.py b/test/models/test_send_digits.py
@@ -26,7 +26,7 @@ class TestSendDigits(unittest.TestCase):
 
     def setUp(self):
         self.model = SendDigits(
-            digits="",
+            digits="TS",
         )
 
     def test_digits(self):
diff --git a/test/models/test_sms.py b/test/models/test_sms.py
@@ -26,9 +26,9 @@ class TestSms(unittest.TestCase):
 
     def setUp(self):
         self.model = Sms(
-            to="",
-            var_from="",
-            text="",
+            to="TS",
+            var_from="TS",
+            text="TS",
         )
 
     def test_to(self):
diff --git a/test/models/test_sms_ten_dlc_brand.py b/test/models/test_sms_ten_dlc_brand.py
@@ -27,12 +27,12 @@ class TestSMSTenDLCBrand(unittest.TestCase):
     def setUp(self):
         self.model = SMSTenDLCBrand(
             entity_type=SMSTenDLCBrandEntityType.PRIVATE_PROFIT,
-            display_name="ABC Mobile",
-            phone="+12024567890",
-            country="US",
-            email="",
+            display_name="TS",
+            phone="TS",
+            country="TS",
+            email="TS",
             brand_relationship=SMSTenDLCBrandRelationship.BASIC_ACCOUNT,
-            vertical="",
+            vertical="TS",
             mock=True,
             identity_status=SMSTenDLCBrandIdentityStatus.SELF_DECLARED,
         )
diff --git a/test/models/test_sms_ten_dlc_campaign.py b/test/models/test_sms_ten_dlc_campaign.py
@@ -26,12 +26,12 @@ class TestSMSTenDLCCampaign(unittest.TestCase):
 
     def setUp(self):
         self.model = SMSTenDLCCampaign(
-            campaign_id="",
-            csp_id="",
-            brand_id="",
-            usecase="",
+            campaign_id="TS",
+            csp_id="TS",
+            brand_id="TS",
+            usecase="TS",
             sub_usecases=[],
-            description="",
+            description="TS",
             mock=True,
         )
 
diff --git a/test/models/test_sms_ten_dlc_partner_campaign.py b/test/models/test_sms_ten_dlc_partner_campaign.py
@@ -26,10 +26,10 @@ class TestSMSTenDLCPartnerCampaign(unittest.TestCase):
 
     def setUp(self):
         self.model = SMSTenDLCPartnerCampaign(
-            campaign_id="",
-            brand_id="",
-            usecase="",
-            description="",
+            campaign_id="TS",
+            brand_id="TS",
+            usecase="TS",
+            description="TS",
         )
 
     def test_account_id(self):
diff --git a/test/models/test_sms_ten_dlc_partner_campaign_brand.py b/test/models/test_sms_ten_dlc_partner_campaign_brand.py
@@ -28,8 +28,8 @@ class TestSMSTenDLCPartnerCampaignBrand(unittest.TestCase):
 
     def setUp(self):
         self.model = SMSTenDLCPartnerCampaignBrand(
-            phone="+12024567890",
-            email="",
+            phone="TS",
+            email="TS",
         )
 
     def test_account_id(self):
diff --git a/test/models/test_sms_toll_free_campaign.py b/test/models/test_sms_toll_free_campaign.py
@@ -26,12 +26,12 @@ class TestSMSTollFreeCampaign(unittest.TestCase):
 
     def setUp(self):
         self.model = SMSTollFreeCampaign(
-            account_id="",
-            campaign_id="",
-            use_case="",
+            account_id="TS",
+            campaign_id="TS",
+            use_case="TS",
             registration_status=SMSTollFreeCampaignRegistrationStatus.UNREGISTERED,
-            date_created="",
-            date_updated="",
+            date_created="TS",
+            date_updated="TS",
             revision=1,
         )
 
diff --git a/test/models/test_tfn.py b/test/models/test_tfn.py
@@ -26,7 +26,7 @@ class TestTFN(unittest.TestCase):
 
     def setUp(self):
         self.model = TFN(
-            campaign_id="",
+            campaign_id="TS",
         )
 
     def test_campaign_id(self):
diff --git a/test/models/test_tfn_campaign.py b/test/models/test_tfn_campaign.py
@@ -26,14 +26,14 @@ class TestTFNCampaign(unittest.TestCase):
 
     def setUp(self):
         self.model = TFNCampaign(
-            account_id="",
+            account_id="TS",
             campaign_id="cmptfn_387ec3f6e03b340553f35f29c8f118cdf3eae08a",
-            use_case="",
+            use_case="TS",
             registration_status=SMSTollFreeCampaignRegistrationStatus.UNREGISTERED,
-            date_created="",
-            date_updated="",
-            date_created_iso="",
-            date_updated_iso="",
+            date_created="TS",
+            date_updated="TS",
+            date_created_iso="TS",
+            date_updated_iso="TS",
             revision=1,
         )
 
diff --git a/test/models/test_transcribe_utterance.py b/test/models/test_transcribe_utterance.py
@@ -26,7 +26,7 @@ class TestTranscribeUtterance(unittest.TestCase):
 
     def setUp(self):
         self.model = TranscribeUtterance(
-            action_url="",
+            action_url="TS",
         )
 
     def test_action_url(self):

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TestAddToConference(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = AddToConference(`
`29`		`- conference_id="",`
	`29`	`+ conference_id="TS",`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`def test_allow_call_control(self):`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TestBuyIncomingNumberRequest(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = BuyIncomingNumberRequest(`
`29`		`- phone_number="",`
	`29`	`+ phone_number="TS",`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`def test_phone_number(self):`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TestCompletionRequest(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = CompletionRequest(`
`29`		`- query="",`
	`29`	`+ query="TS",`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`def test_query(self):`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TestCreateConference(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = CreateConference(`
`29`		`- action_url="",`
	`29`	`+ action_url="TS",`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`def test_action_url(self):`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ class TestCreateWebRTCToken(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = CreateWebRTCToken(`
`29`		`- to="",`
`30`		`- var_from="",`
	`29`	`+ to="TS",`
	`30`	`+ var_from="TS",`
`31`	`31`	`uses=1,`
`32`	`32`	`)`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TestFilterLogsRequest(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = FilterLogsRequest(`
`29`		`- pql="",`
	`29`	`+ pql="TS",`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`def test_pql(self):`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ class TestGetDigits(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = GetDigits(`
`29`		`- action_url="",`
	`29`	`+ action_url="TS",`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`def test_action_url(self):`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ class TestGetSpeech(unittest.TestCase):`
`26`	`26`
`27`	`27`	`def setUp(self):`
`28`	`28`	`self.model = GetSpeech(`
`29`		`- action_url="",`
`30`		`- grammar_file="",`
	`29`	`+ action_url="TS",`
	`30`	`+ grammar_file="TS",`
`31`	`31`	`)`
`32`	`32`
`33`	`33`	`def test_action_url(self):`