rgbkbd: Send unlimited number of LEDs with multiple HCs

Signed-off-by: Daniel Schaefer <[email protected]>

Author: JohnAZoidberg

framework_lib/src/chromium_ec/mod.rs

@@ -923,17 +923,19 @@ impl CrosEc {
     }
 
     pub fn rgbkbd_set_color(&self, start_key: u8, colors: Vec<RgbS>) -> EcResult<()> {
-        let mut request = EcRequestRgbKbdSetColor {
-            start_key,
-            length: colors.len() as u8,
-            color: [(); EC_RGBKBD_MAX_KEY_COUNT].map(|()| Default::default()),
-        };
+        for (chunk, colors) in colors.chunks(EC_RGBKBD_MAX_KEY_COUNT).enumerate() {
+            let mut request = EcRequestRgbKbdSetColor {
+                start_key: start_key + ((chunk * EC_RGBKBD_MAX_KEY_COUNT) as u8),
+                length: colors.len() as u8,
+                color: [(); EC_RGBKBD_MAX_KEY_COUNT].map(|()| Default::default()),
+            };
 
-        for (i, color) in colors.iter().enumerate() {
-            request.color[i] = *color;
-        }
+            for (i, color) in colors.iter().enumerate() {
+                request.color[i] = *color;
+            }
 
-        let _res = request.send_command(self)?;
+            let _res = request.send_command(self)?;
+        }
         Ok(())
     }
 }

framework_lib/src/commandline/clap_std.rs

@@ -4,7 +4,6 @@
 use clap::Parser;
 use clap_num::maybe_hex;
 
-use crate::chromium_ec::commands::EC_RGBKBD_MAX_KEY_COUNT;
 use crate::chromium_ec::CrosEcDriverType;
 use crate::commandline::{
     Cli, ConsoleArg, FpBrightnessArg, HardwareDeviceType, InputDeckModeArg, RebootEcArg,
@@ -154,7 +153,7 @@ struct ClapCli {
     /// Set the color of <key> to <RGB>. Multiple colors for adjacent keys can be set at once.
     /// <key> <RGB> [<RGB> ...]
     /// Example: 0 0xFF000 0x00FF00 0x0000FF
-    #[clap(num_args = 2..EC_RGBKBD_MAX_KEY_COUNT)]
+    #[clap(num_args = 2..)]
     #[arg(long, value_parser=maybe_hex::<u64>)]
     rgbkbd: Vec<u64>,