Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add port autodetection and make port parameter optional #238

Open
3 tasks
mindsolve opened this issue Aug 6, 2024 · 0 comments
Open
3 tasks

C#: Add port autodetection and make port parameter optional #238

mindsolve opened this issue Aug 6, 2024 · 0 comments
Labels
good first issue Good for newcomers lang: C# Affects the C# version of minestat new feature Request something new

Comments

@mindsolve
Copy link
Collaborator

Feature Description

We should have feature parity between different MineStat editions. The Python (and other) editions made the port parameter optional, if it can be automatically detected, e.g. through SRV records or default ports.

  • Add port autodetection for default ports
  • Make port parameter optional
  • Document new usage patterns in README and docstring

Originally proposed by @nimeng1299 in issue #237
@mindsolve mindsolve added new feature Request something new lang: C# Affects the C# version of minestat labels Aug 6, 2024
@mindsolve mindsolve mentioned this issue Aug 6, 2024
Open
@mindsolve mindsolve added the good first issue Good for newcomers label Aug 6, 2024
@smellilac smellilac mentioned this issue Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers lang: C# Affects the C# version of minestat new feature Request something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made the port optional smellilac/minestat
1 participant
@mindsolve