Skip to content

Commit c514d22

Browse files
committed
Update protobuf dependency
1 parent cda59cc commit c514d22

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/metadata/MetaDataEvolutionValidator.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.common.collect.BiMap;
3030
import com.google.common.collect.HashBiMap;
3131
import com.google.common.collect.Sets;
32+
import com.google.protobuf.DescriptorProtos;
3233
import com.google.protobuf.Descriptors;
3334
import com.google.protobuf.Descriptors.Descriptor;
3435
import com.google.protobuf.Descriptors.EnumDescriptor;
@@ -251,10 +252,11 @@ private void validateMessage(@Nonnull Descriptor oldDescriptor, @Nonnull Descrip
251252
}
252253
}
253254

254-
@SuppressWarnings("deprecation") // checks the deprecated syntax field
255255
private void validateProtoSyntax(@Nonnull Descriptors.Descriptor oldDescriptor, @Nonnull Descriptors.Descriptor newDescriptor) {
256-
if (!oldDescriptor.getFile().getSyntax().equals(newDescriptor.getFile().getSyntax())
257-
|| !oldDescriptor.getFile().getEdition().equals(newDescriptor.getFile().getEdition())) {
256+
final DescriptorProtos.FileDescriptorProto oldFileDescriptorProto = oldDescriptor.getFile().toProto();
257+
final DescriptorProtos.FileDescriptorProto newFileDescriptorProto = newDescriptor.getFile().toProto();
258+
if (!oldFileDescriptorProto.getSyntax().equals(oldFileDescriptorProto.getSyntax())
259+
|| !oldFileDescriptorProto.getEdition().equals(newFileDescriptorProto.getEdition())) {
258260
throw new MetaDataException("message descriptor proto syntax changed",
259261
LogMessageKeys.RECORD_TYPE, oldDescriptor.getName());
260262
}

fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/metadata/MetaDataEvolutionValidatorTestV3.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public void nestedProto2ToProto3() {
148148
@SuppressWarnings("deprecation") // test focuses on checking the (deprecated) syntax field
149149
@Test
150150
public void onlyFileProto2ToProto3() throws InvalidProtocolBufferException {
151-
assertNotEquals(TestRecords1Proto.getDescriptor().getSyntax(), TestRecords1ImportedProto.getDescriptor().getSyntax());
151+
assertNotEquals(TestRecords1Proto.getDescriptor().toProto().getSyntax(), TestRecords1ImportedProto.getDescriptor().toProto().getSyntax());
152152
MetaDataEvolutionValidator.getDefaultInstance().validateUnion(
153153
TestRecords1Proto.RecordTypeUnion.getDescriptor(),
154154
TestRecords1ImportedProto.RecordTypeUnion.getDescriptor()

gradle/libs.versions.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ fdb = "7.1.26"
3535
geophile = "2.3.0"
3636
generatedAnnotation = "1.3.2"
3737
grpc = "1.64.1"
38-
grpc-commonProtos = "2.37.0"
38+
grpc-commonProtos = "2.54.1"
3939
guava = "33.3.1-jre"
4040
h2 = "1.3.148"
4141
icu = "69.1"
@@ -47,7 +47,7 @@ jts = "1.16.1"
4747
log4j = "2.23.1"
4848
prometheus = "0.16.0"
4949
prometheus-grpc = "0.6.0"
50-
protobuf = "3.25.5"
50+
protobuf = "4.30.1"
5151
sqlline = "1.12.0"
5252
slf4j = "1.7.36"
5353

0 commit comments

Comments
 (0)