Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtOperatorUpdate::update() is parsing query for each document #156

Open
apkar opened this issue Apr 11, 2019 · 2 comments · May be fixed by #215
Open

ExtOperatorUpdate::update() is parsing query for each document #156

apkar opened this issue Apr 11, 2019 · 2 comments · May be fixed by #215
Assignees
@senthil-db-expert
Milestone
2.0.0

Comments

@apkar
Copy link
Contributor

apkar commented Apr 11, 2019

This function gets executed part plan execution phase, but it tries to parse and figure out the query here in this function. This function gets executed for each and every document we scan, most of the work in this function could be pushed to the planning phase.

It's possible I am being naive and expecting this to be simpler than it is, but it is worth spending a bit of time on it later.
@dongxinEric
Copy link
Contributor

I agree. The query parsing and validating part can be lifted into the constructor of ExtOperatorUpdate and ExtReplaceUpdate.

@apkar apkar added this to the 1.8.0 milestone Apr 15, 2019
@apkar apkar modified the milestones: 1.8.0, 2.0.0 Aug 12, 2019
@senthil-db-expert
Copy link

@apkar Could you please assign this to me, we started working on it.

sakthivel-axim added a commit to sakthivel-axim/fdb-document-layer that referenced this issue Sep 23, 2019
@sakthivel-axim
Resolves FoundationDB#156: The query parsing and validation part move…
37149f8 
…d to the updateDocument constructor
@sakthivel-axim sakthivel-axim linked a pull request Sep 23, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senthil-db-expert senthil-db-expert

Labels
None yet
Projects
None yet
Milestone
2.0.0
3 participants
@dongxinEric @apkar @senthil-db-expert