-
-
Notifications
You must be signed in to change notification settings - Fork 25
Support System.Text.Json #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I removed some usages of JSON.NET down to where our only usage is pretty much the JSON patch support. Spent some time taking a look at json-everything's |
Found this issue where someone asked him and he said no to supporting JSON Path. |
Comment for previous history: For Json Patching it would be nice to see if we can get it to work without a dependency or we can internalize the dependency. I see several spots doing patching
|
Initial support for STJ was added in #97 We still need to support Patching |
Currently users of this library using System.Text.Json (STJ) cannot return search aggregation results (from redis cache, or from api endpoints) due to serialization dependencies on Newtonsoft.Json. Our goal is to update the Foundatio.Repositories to work with System.Text.Json. However, we don’t want to break other applications so we need to support Newtonsoft.Json by leaving the existing JsonConverters in place unless we can find a way to support both out of the box without the dependency or an easy way for it to be configured externally.
I see this happening in the following steps:
AggregationQueryTests.GetTermAggregationsWithTopHitsAsync()
.Foundatio.Repositories.Utility
to System.Text.Json and then add the json converter attributes next to the existing converter attributes. This will fix the round trip part of reading the json text.Not sure if this link will help on the converters: https://bengribaudo.com/blog/2022/02/22/6569/recursive-polymorphic-deserialization-with-system-text-json
The text was updated successfully, but these errors were encountered: