feat(react-journey): add react journey app #86
+41,899
−19,723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanbas21
reviewed
Jan 12, 2026
javascript/react-journey/README.md
Outdated
| ## Requirements | ||
|
|
||
| 1. An instance of Ping's Access Manager (AM), either within a Ping's Advanced Identity Cloud tenant, your own private installation or locally installed on your computer | ||
| 2. Node >= 14.2.0 (recommended: install via [official package installer](https://nodejs.org/en/)) |
Contributor
There was a problem hiding this comment.
maybe we should update this to a newer node, we dont test this far back so maybe 18? 18 is still pretty old
Contributor
Author
There was a problem hiding this comment.
updated to 18.12.0
ryanbas21
reviewed
Jan 12, 2026
javascript/react-journey/client/components/journey/identity-provider.js
Outdated
Show resolved
Hide resolved
| */ | ||
|
|
||
| // TODO: Have we ported over HttpClient yet? | ||
| import { HttpClient } from '@forgerock/javascript-sdk'; |
Contributor
There was a problem hiding this comment.
We haven't but i think we could probably remove this and use a plain fetch
ancheetah
force-pushed
the
SDKS-4047-react-journey
branch
2 times, most recently
from
cc7c400 to
3962b82
Compare
ancheetah
force-pushed
the
SDKS-4047-react-journey
branch
4 times, most recently
from
23683ad to
b09f40e
Compare
ancheetah
force-pushed
the
SDKS-4047-react-journey
branch
from
b09f40e to
315978c
Compare
Contributor
Author
|
Please review "SDK Integration" comments and OIDC Context |
ryanbas21
approved these changes
Jan 20, 2026
cerebrl
approved these changes
Jan 20, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
This looks good. I have one non-blocking that we can address in a follow up PR.
| * @function useOidcClient - A custom hook to access the OIDC client from React Context | ||
| * @returns - An OIDC client if it exists otherwise an error | ||
| */ | ||
| export function useOidcClient() { |
Contributor
There was a problem hiding this comment.
It seems this module differs a bit from the global-state.js pattern. Can we make sure these are consistent in both file name and internal patterns?
See the screenshot attached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://pingidentity.atlassian.net/browse/SDKS-4047
TODO:
DO NOT MERGE: Pending release of journey client and oidc client. OIDC and Journey package dependencies need to be updated.