chore: pr-review

Add build and API docs steps to publish actions and workflows

- Run builds and generate API docs before publishing in beta and release
actions - Use --no-agents flag for Nx build steps in workflows - Remove
NX_CLOUD_DISTRIBUTED_EXECUTION env and related config - Remove E2E
report upload step from CI workflow - Minor improvements to setup action
step names

Author: ryanbas21

.github/actions/publish-beta/action.yml

@@ -8,6 +8,14 @@ runs:
       shell: bash
       run: pnpm pkg-pr-new publish './packages/*' './packages/sdk-effects/*' --packageManager=pnpm --comment=off
 
+    - name: Run Builds
+      shell: bash
+      run: pnpm nx run-many -t build --no-agents
+
+    - name: Generate API Docs
+      shell: bash
+      run: pnpm generate-docs
+
     - name: Publish api docs [beta]
       uses: JamesIves/[email protected]
       with:

.github/actions/publish-release/action.yml

@@ -30,6 +30,14 @@ runs:
             "publishedPackages": "${{ steps.slackify.outputs.message }}"
           }
 
+    - name: Run Builds
+      shell: bash
+      run: pnpm nx run-many -t build --no-agents
+
+    - name: Generate API Docs
+      shell: bash
+      run: pnpm generate-docs
+
     - name: Publish api docs
       uses: JamesIves/[email protected]
       with:

.github/actions/setup/action.yml

@@ -56,7 +56,8 @@ runs:
       run: pnpm exec playwright install
       shell: bash
 
-    - uses: nrwl/nx-set-shas@v4
+    - name: Set Nx SHAs
+      uses: nrwl/nx-set-shas@v4
 
     - name: Check TS References are Synced
       shell: bash

.github/workflows/ci-fork.yml

@@ -53,4 +53,4 @@ jobs:
       - run: git branch --track main origin/main || true
 
       - run: pnpm nx format:check
-      - run: pnpm nx affected -t build typecheck lint test e2e-ci
+      - run: pnpm nx affected -t build typecheck lint test e2e-ci --no-agents

.github/workflows/ci.yml

@@ -5,7 +5,6 @@ on:
 env:
   NX_CLOUD_ENCRYPTION_KEY: ${{ secrets.NX_CLOUD_ENCRYPTION_KEY }}
   NX_CLOUD_ACCESS_TOKEN: ${{ secrets.PR_NX_CLOUD_ACCESS_TOKEN }} # Read Only
-  NX_CLOUD_DISTRIBUTED_EXECUTION: true
   CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
   CI: true
 
@@ -22,7 +21,6 @@ jobs:
     permissions:
       pull-requests: write
       contents: write
-      id-token: write
     steps:
       - uses: actions/checkout@v4
         with:
@@ -43,9 +41,7 @@ jobs:
           token: ${{ secrets.CODECOV_TOKEN }}
 
       - name: Ensure builds run
-        run: pnpm nx run-many -t build
-        env:
-          NX_CLOUD_DISTRIBUTED_EXECUTION: false
+        run: pnpm nx run-many -t build --no-agents
 
       - run: pnpm pkg-pr-new publish './packages/*' './packages/sdk-effects/*' --packageManager=pnpm
 
@@ -138,14 +134,3 @@ jobs:
 
             ---
             <sub>🔄 Updated automatically on each push to this PR</sub>
-
-      - name: Upload E2E reports on failure
-        if: failure()
-        uses: actions/upload-artifact@v4
-        with:
-          name: e2e-reports
-          path: |
-            e2e/*-suites/playwright-report/**
-            e2e/*-suites/test-results/**
-            e2e/*-suites/.playwright/**
-          retention-days: 7

.github/workflows/publish.yml

@@ -28,7 +28,6 @@ on:
 env:
   NX_CLOUD_ENCRYPTION_KEY: ${{ secrets.NX_CLOUD_ENCRYPTION_KEY }}
   NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
-  NX_CLOUD_DISTRIBUTED_EXECUTION: true
   PNPM_CACHE_FOLDER: .pnpm-store
   CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
   CI: true
@@ -115,8 +114,6 @@ jobs:
       - name: Setup Project
         uses: ./.github/actions/setup
         with:
-          node-version-file: '.node-version'
-          pnpm-cache-folder: .pnpm-store
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
 
       - name: Version Packages as prerelease