Merge PR OCA#919 into 13.0

Signed-off-by pedrobaeza

Author: OCA-git-bot

account_global_discount/models/account_move.py

@@ -9,6 +9,15 @@
 class AccountMove(models.Model):
     _inherit = "account.move"
 
+    # HACK: Looks like UI doesn't behave well with Many2many fields and
+    # negative groups when the same field is shown. In this case, we want to
+    # show the readonly version to any not in the global discount group.
+    # TODO: Check if it's fixed in future versions
+    global_discount_ids_readonly = fields.Many2many(
+        string="Invoice Global Discounts (readonly)",
+        related="global_discount_ids",
+        readonly=True,
+    )
     global_discount_ids = fields.Many2many(
         comodel_name="global.discount",
         column1="invoice_id",
@@ -262,6 +271,16 @@ def _compute_amount(self):
         for record in self:
             record._compute_amount_one()
 
+    @api.model_create_multi
+    def create(self, vals_list):
+        """If we create the invoice with the discounts already set like from
+        a sales order, we must compute the global discounts as well"""
+        moves = super().create(vals_list)
+        move_with_global_discounts = moves.filtered("global_discount_ids")
+        for move in move_with_global_discounts:
+            move.with_context(check_move_validity=False)._onchange_invoice_line_ids()
+        return moves
+
 
 class AccountMoveLine(models.Model):
     _inherit = "account.move.line"

account_global_discount/views/account_invoice_views.xml

@@ -14,6 +14,14 @@
                     name="global_discount_ids"
                     widget="many2many_tags"
                     placeholder="Discounts..."
+                    groups="base_global_discount.group_global_discount"
+                />
+                <field
+                    string="Invoice Global Discounts"
+                    name="global_discount_ids_readonly"
+                    widget="many2many_tags"
+                    readonly="1"
+                    groups="!base_global_discount.group_global_discount"
                 />
             </xpath>
             <field name="amount_untaxed" position="before">

account_global_discount/views/global_discount_views.xml

@@ -34,6 +34,7 @@
         id="menu_account_global_discount"
         action="base_global_discount.action_global_discount_tree"
         name="Global Discounts"
+        groups="base_global_discount.group_global_discount"
         parent="account.account_management_menu"
     />
 </odoo>