Skip to content

JsonObjectFile::IsCorrectExtension → IsSupportedExtension #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ForNeVeR opened this issue Apr 9, 2025 · 0 comments · Fixed by #798
Closed

JsonObjectFile::IsCorrectExtension → IsSupportedExtension #800

ForNeVeR opened this issue Apr 9, 2025 · 0 comments · Fixed by #798
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:refactor Internal changes not affecting the compiler behavior status:help-wanted Open for contributors

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Apr 9, 2025 •
edited
Loading

Originally posted by @kant2002 in #798 (comment)

I notice name of this function. Should be rename it to something more appropriate like IsSupportedExtension, or IsObjectFileExtension ?
@ForNeVeR ForNeVeR added status:help-wanted Open for contributors area:compiler Related to code compilation or type checking kind:refactor Internal changes not affecting the compiler behavior good-first-issue An issue considered simple enough for new contributors labels Apr 9, 2025
ForNeVeR added a commit to leha-bot/Cesium that referenced this issue Apr 9, 2025
@ForNeVeR
(ForNeVeR#800) Introduce JsonObjectFile.IsSupportedExtension
182335c
@ForNeVeR ForNeVeR mentioned this issue Apr 9, 2025
Merged
ForNeVeR added a commit that referenced this issue Apr 9, 2025
@ForNeVeR
(#800) Introduce JsonObjectFile.IsSupportedExtension
09f30eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors kind:refactor Internal changes not affecting the compiler behavior status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JsonObjectFile: Support also ".o" extension leha-bot/Cesium
1 participant
@ForNeVeR