Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog doesnt correctly disable group name #1633

Closed
JulianStremel opened this issue Mar 17, 2025 · 3 comments · Fixed by #1637
Closed

Dialog doesnt correctly disable group name #1633

JulianStremel opened this issue Mar 17, 2025 · 3 comments · Fixed by #1637
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@JulianStremel
Copy link
Contributor

JulianStremel commented Mar 17, 2025

Current Behavior

The Dialog Group does show "Dialog" as Groupname even if "Display group name" is disabled.

If enabled the correct group name is displayed (Dialog-LR) in my case.

Image

Expected Behavior

I would expect there to be no additional headers in the dialog if disabled like every other group.

Steps To Reproduce

Create a dialog group in a dashboard and turn off "Display group name".

Environment

  • Dashboard version: 1.22.1
  • Node-RED version: 4.0.2
  • Node.js version:
  • npm version:
  • Platform/OS: Arm64/Ubuntu
  • Browser: Chrome/Webkit/Chromium
@JulianStremel JulianStremel added bug Something isn't working needs-triage Needs looking at to decide what to do labels Mar 17, 2025
@JulianStremel
Copy link
Contributor Author

JulianStremel commented Mar 17, 2025

My current workaround is adding a template node scoped to that group with:

<style>
    .v-card-item__content {
        display: none;
    }
    .v-card-item__append {
        display: none;
    }
</style>

@bartbutenaers
Copy link
Contributor

@JulianStremel ,
Here you go.
Note that my PR needs to be reviewed and merged by somebody from FlowFuse.
Bart

@JulianStremel
Copy link
Contributor Author

@JulianStremel ,
Here you go.
Note that my PR needs to be reviewed and merged by somebody from FlowFuse.
Bart

Thank you!
Will keep this open until your fix is merged for reference :)

@github-project-automation github-project-automation bot moved this from Backlog to Done in Dashboard Backlog Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants