Skip to content

Commit c0ad7cb

Browse files
committed
fix logic
1 parent 33ec6b2 commit c0ad7cb

File tree

3 files changed

+22
-26
lines changed

3 files changed

+22
-26
lines changed

frontend/common/services/useUserPermissions.ts

+1-11
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,7 @@ export const userPermissionsService = service
7272
admin: false,
7373
permissions: [
7474
{
75-
derived_from: {
76-
roles: [
77-
{
78-
'description': 'role_1',
79-
'id': 227,
80-
'name': 'role1',
81-
'organisation': 5692,
82-
tags: [],
83-
},
84-
],
85-
},
75+
derived_from: undefined,
8676
is_directly_granted: true,
8777
permission_key: 'MANAGE_USERS',
8878
tags: [],

frontend/web/components/DerivedPermissionsList.tsx

+17-14
Original file line numberDiff line numberDiff line change
@@ -42,26 +42,23 @@ const DerivedPermissionsList: FC<DerivedPermissionsListType> = ({
4242
numberToTruncate = 3,
4343
}) => {
4444
const { items, truncatedItems } = useMemo(() => {
45-
if (
46-
isAdmin ||
47-
!derivedPermissions ||
48-
!derivedPermissions.groups ||
49-
!derivedPermissions.roles
50-
) {
45+
if (isAdmin || !derivedPermissions) {
5146
return {
5247
items: [],
5348
truncatedItems: [],
5449
}
5550
}
5651

57-
const groups = derivedPermissions.groups.map((group) => ({
58-
...group,
59-
type: 'group' as const,
60-
}))
61-
const roles = derivedPermissions.roles.map((role) => ({
62-
...role,
63-
type: 'role' as const,
64-
}))
52+
const groups =
53+
derivedPermissions?.groups?.map((group) => ({
54+
...group,
55+
type: 'group' as const,
56+
})) ?? []
57+
const roles =
58+
derivedPermissions?.roles?.map((role) => ({
59+
...role,
60+
type: 'role' as const,
61+
})) ?? []
6562
const derivedList = [...groups, ...roles]
6663

6764
const items =
@@ -75,6 +72,12 @@ const DerivedPermissionsList: FC<DerivedPermissionsListType> = ({
7572
}
7673
}, [isAdmin, numberToTruncate, derivedPermissions])
7774

75+
console.log({
76+
derivedPermissions,
77+
items,
78+
truncatedItems,
79+
})
80+
7881
if (!items?.length) return null
7982

8083
return (

frontend/web/components/PermissionRow.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ export const PermissionRow: React.FC<PermissionRowProps> = ({
8484
(e) => e.permission_key === permission.key,
8585
)
8686

87+
console.log(matchingPermission)
88+
8789
const hasPermission = (key: string) => {
8890
if (isAdmin) return true
8991
return entityPermissions.permissions.find(
@@ -141,9 +143,10 @@ export const PermissionRow: React.FC<PermissionRowProps> = ({
141143
}}
142144
/>
143145
)}
144-
{isDebug && !isAdmin && (
146+
{isDebug && (
145147
<div className='mt-2'>
146148
<DerivedPermissionsList
149+
isAdmin={isAdmin}
147150
derivedPermissions={
148151
(matchingPermission as Permission)?.derived_from
149152
}

0 commit comments

Comments
 (0)