fix(identity-cache-key): Use hashed identifier (#68)

gagantrivedi · web-flow · commit a0b1c227c1ce · 2024-03-19T16:29:53.000+05:30
* fix(identity-cache-key): Use hashed identifier

* bump patch version
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "flagsmith/flagsmith-php-client",
     "type": "library",
-    "version": "v4.2.0",
+    "version": "v4.2.1",
     "license": "BSD-3-Clause",
     "authors": [
         {
diff --git a/src/Utils/IdentitiesGenerator.php b/src/Utils/IdentitiesGenerator.php
@@ -23,6 +23,7 @@ public static function generateIdentitiesData(string $identifier, ?object $trait
     public static function generateIdentitiesCacheKey(string $identifier, ?object $traits)
     {
         $hashedTraits = $traits !== null ? '.'.sha1(serialize($traits)) : '';
-        return 'Identity.'.$identifier.$hashedTraits;
+        $hashedIdentifier = sha1($identifier);
+        return 'Identity.'.$hashedIdentifier.$hashedTraits;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "flagsmith/flagsmith-php-client",`
`3`	`3`	`"type": "library",`
`4`		`- "version": "v4.2.0",`
	`4`	`+ "version": "v4.2.1",`
`5`	`5`	`"license": "BSD-3-Clause",`
`6`	`6`	`"authors": [`
`7`	`7`	`{`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ public static function generateIdentitiesData(string $identifier, ?object $trait`
`23`	`23`	`public static function generateIdentitiesCacheKey(string $identifier, ?object $traits)`
`24`	`24`	`{`
`25`	`25`	`$hashedTraits = $traits !== null ? '.'.sha1(serialize($traits)) : '';`
`26`		`- return 'Identity.'.$identifier.$hashedTraits;`
	`26`	`+ $hashedIdentifier = sha1($identifier);`
	`27`	`+ return 'Identity.'.$hashedIdentifier.$hashedTraits;`
`27`	`28`	`}`
`28`	`29`	`}`