Skip to content

Commit 80608e6

Browse files
authored
Merge pull request #53 from floranpagliai/main
Fix local evaluation when values are null
2 parents f044353 + 0300383 commit 80608e6

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/Concerns/JsonSerializer.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,17 @@ protected function setValues($values)
2525
{
2626
foreach ($values as $key => $value) {
2727
if (isset($this->keys[$key])) {
28+
if (null === $value) {
29+
continue;
30+
}
2831
$className = $this->keys[$key];
2932
if (method_exists($className, 'build')) {
30-
$this->{ $key } = $className::build($value);
33+
$this->{$key} = $className::build($value);
3134
} else {
32-
$this->{ $key} = new $className($value);
35+
$this->{$key} = new $className($value);
3336
}
3437
} else {
35-
$this->{ $key } = $value;
38+
$this->{$key} = $value;
3639
}
3740
}
3841
}

tests/Engine/Unit/Environments/EnvironmentBuilderTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,5 +165,6 @@ public function testBuildEnvironmentApiKeyModel()
165165

166166
$environment = EnvironmentAPIKeyModel::build($environmentDict);
167167
$this->assertEquals($environment->getKey(), $environmentDict->key);
168+
$this->assertNull($environment->expires_at);
168169
}
169170
}

0 commit comments

Comments
 (0)