Merge pull request #7 from tm1000/patch-1

dabeeeenster · web-flow · commit 0c6e35628c9d · 2021-10-29T18:59:38.000+01:00
Check cache for useCacheAsFailover
diff --git a/src/Flagsmith.php b/src/Flagsmith.php
@@ -489,7 +489,10 @@ private function cachedCall(
                 $response = $this->call($method, $uri, $body);
                 $this->cache->set($cacheKey, $response);
             } catch (APIException $e) {
-                if (!$this->useCacheAsFailover) {
+                if (
+                    !$this->useCacheAsFailover ||
+                    !$this->cache->has($cacheKey)
+                   ) {
                     throw $e;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,10 @@ private function cachedCall(`
`489`	`489`	`$response = $this->call($method, $uri, $body);`
`490`	`490`	`$this->cache->set($cacheKey, $response);`
`491`	`491`	`} catch (APIException $e) {`
`492`		`- if (!$this->useCacheAsFailover) {`
	`492`	`+ if (`
	`493`	`+ !$this->useCacheAsFailover \|\|`
	`494`	`+ !$this->cache->has($cacheKey)`
	`495`	`+ ) {`
`493`	`496`	`throw $e;`
`494`	`497`	`}`
`495`	`498`	`}`