Skip to content

Commit fab1413

Browse files
authored
perf: rm railToDataSet mapping for cdn rails (#278)
Reviewer @rvagg CC @Chaitu-Tatipamula Closes #277 Resolves #269 (review) We are able to remove this mapping because it is only used by IValidator functions, and, since #237, FWSS is not the IValidator for these rails. This reduces codesize 23,991 -> 23,898 (-93) #### Changes * remove railToDataSet mapping for both cdn rails
1 parent 1837576 commit fab1413

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

service_contracts/src/FilecoinWarmStorageService.sol

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,6 @@ contract FilecoinWarmStorageService is
626626
address(this) // controller
627627
);
628628
info.cacheMissRailId = cacheMissRailId;
629-
railToDataSet[cacheMissRailId] = dataSetId;
630629
payments.modifyRailLockup(cacheMissRailId, DEFAULT_LOCKUP_PERIOD, DEFAULT_CACHE_MISS_LOCKUP_AMOUNT);
631630

632631
cdnRailId = payments.createRail(
@@ -638,7 +637,6 @@ contract FilecoinWarmStorageService is
638637
address(this) // controller
639638
);
640639
info.cdnRailId = cdnRailId;
641-
railToDataSet[cdnRailId] = dataSetId;
642640
payments.modifyRailLockup(cdnRailId, DEFAULT_LOCKUP_PERIOD, DEFAULT_CDN_LOCKUP_AMOUNT);
643641

644642
emit CDNPaymentRailsToppedUp(dataSetId, DEFAULT_CDN_LOCKUP_AMOUNT, DEFAULT_CACHE_MISS_LOCKUP_AMOUNT);
@@ -704,10 +702,6 @@ contract FilecoinWarmStorageService is
704702

705703
// Clean up rail mappings
706704
delete railToDataSet[info.pdpRailId];
707-
if (dataSetHasCDNMetadataKey(dataSetId)) {
708-
delete railToDataSet[info.cacheMissRailId];
709-
delete railToDataSet[info.cdnRailId];
710-
}
711705

712706
// Clean up metadata mappings
713707
string[] storage metadataKeys = dataSetMetadataKeys[dataSetId];

service_contracts/test/FilecoinWarmStorageService.t.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,6 @@ contract FilecoinWarmStorageServiceTest is Test {
605605
assertEq(clientDataSetIds[0], newDataSetId);
606606

607607
assertEq(viewContract.railToDataSet(pdpRailId), newDataSetId);
608-
assertEq(viewContract.railToDataSet(cdnRailId), newDataSetId);
609608

610609
// Verify data set info
611610
FilecoinWarmStorageService.DataSetInfoView memory dataSetInfo = viewContract.getDataSet(newDataSetId);

0 commit comments

Comments
 (0)