Use NumberInput helper methods for parsing (#237)

Author: pjfanning

datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/DecimalUtils.java

@@ -16,6 +16,8 @@
 
 package com.fasterxml.jackson.datatype.jsr310;
 
+import com.fasterxml.jackson.core.io.NumberInput;
+
 import java.math.BigDecimal;
 import java.time.Instant;
 import java.util.function.BiFunction;
@@ -92,7 +94,7 @@ public static BigDecimal toBigDecimal(long seconds, int nanoseconds)
             }
             return BigDecimal.valueOf(seconds).setScale(9);
         }
-        return new BigDecimal(toDecimal(seconds, nanoseconds));
+        return NumberInput.parseBigDecimal(toDecimal(seconds, nanoseconds));
     }
 
     /**
@@ -104,7 +106,7 @@ public static int extractNanosecondDecimal(BigDecimal value, long integer)
         // !!! 14-Mar-2016, tatu: Somewhat inefficient; should replace with functionally
         //   equivalent code that just subtracts integral part? (or, measure and show
         //   there's no difference and do nothing... )
-        return value.subtract(new BigDecimal(integer)).multiply(ONE_BILLION).intValue();
+        return value.subtract(BigDecimal.valueOf(integer)).multiply(ONE_BILLION).intValue();
     }
 
     /**
@@ -136,7 +138,7 @@ else if (seconds.scale() < -63) {
         else {
             // Now we know that seconds has reasonable scale, we can safely chop it apart.
             secondsOnly = seconds.longValue();
-            nanosOnly = nanoseconds.subtract(new BigDecimal(secondsOnly).scaleByPowerOfTen(9)).intValue();
+            nanosOnly = nanoseconds.subtract(BigDecimal.valueOf(secondsOnly).scaleByPowerOfTen(9)).intValue();
 
             if (secondsOnly < 0 && secondsOnly > Instant.MIN.getEpochSecond()) {
                 // Issue #69 and Issue #120: avoid sending a negative adjustment to the Instant constructor, we want this as the actual nanos

datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/deser/InstantDeserializer.java

@@ -20,6 +20,7 @@
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.core.JsonTokenId;
+import com.fasterxml.jackson.core.io.NumberInput;
 import com.fasterxml.jackson.databind.BeanProperty;
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.DeserializationFeature;
@@ -272,10 +273,10 @@ protected T _fromString(JsonParser p, DeserializationContext ctxt,
             if (dots >= 0) { // negative if not simple number
                 try {
                     if (dots == 0) {
-                        return _fromLong(ctxt, Long.parseLong(string));
+                        return _fromLong(ctxt, NumberInput.parseLong(string));
                     }
                     if (dots == 1) {
-                        return _fromDecimal(ctxt, new BigDecimal(string));
+                        return _fromDecimal(ctxt, NumberInput.parseBigDecimal(string));
                     }
                 } catch (NumberFormatException e) {
                     // fall through to default handling, to get error there