From 72c59e0b0264b7f12648058e178dc43d1ae95a1e Mon Sep 17 00:00:00 2001 From: wrongwrong Date: Sat, 30 Dec 2023 22:16:08 +0900 Subject: [PATCH 1/2] The serialVersionUID is set to private Steps such as deprecation were ignored since the property is of no particular use. --- pom.xml | 1 + .../kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 630e81802..348afb9bd 100644 --- a/pom.xml +++ b/pom.xml @@ -234,6 +234,7 @@ com.fasterxml.jackson.module.kotlin.SequenceSerializer + com.fasterxml.jackson.module.kotlin.KotlinModule#serialVersionUID diff --git a/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt b/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt index 8505c2c6c..8846b8079 100644 --- a/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt +++ b/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt @@ -59,7 +59,7 @@ class KotlinModule @Deprecated( ) : SimpleModule(KotlinModule::class.java.name, PackageVersion.VERSION) { companion object { // Increment when option is added - const val serialVersionUID = 2L + private const val serialVersionUID = 2L } init { From 70265c9be7fff43631fe7c99c7d1b3e487ab7377 Mon Sep 17 00:00:00 2001 From: wrongwrong Date: Sat, 30 Dec 2023 22:18:44 +0900 Subject: [PATCH 2/2] Update release notes wrt #746 --- release-notes/CREDITS-2.x | 1 + release-notes/VERSION-2.x | 1 + 2 files changed, 2 insertions(+) diff --git a/release-notes/CREDITS-2.x b/release-notes/CREDITS-2.x index 7e8c01e42..6f21d2b11 100644 --- a/release-notes/CREDITS-2.x +++ b/release-notes/CREDITS-2.x @@ -18,6 +18,7 @@ Contributors: # 2.17.0 (not yet released) WrongWrong (@k163377) +* #746: The KotlinModule#serialVersionUID is set to private. * #745: Modified isKotlinClass determination method. * #744: API deprecation update for KotlinModule. * #743: Fix handling of vararg deserialization. diff --git a/release-notes/VERSION-2.x b/release-notes/VERSION-2.x index b71c0f6b9..0ea6041c8 100644 --- a/release-notes/VERSION-2.x +++ b/release-notes/VERSION-2.x @@ -18,6 +18,7 @@ Co-maintainers: 2.17.0 (not yet released) +#746: The KotlinModule#serialVersionUID is set to private. #745: Modified isKotlinClass determination method. #744: Functions that were already marked as deprecated, such as the primary constructor in KotlinModule and some functions in Builder,