Optimize KotlinAnnotationIntrospector#AnnotatedMethod.hasRequiredMarker method.
#449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
force-pushed
the
optimize_instrospector
branch
from
8054fda to
eb913c6
Compare
k163377
force-pushed
the
optimize_instrospector
branch
from
eb913c6 to
64a748c
Compare
|
@dinomite It would be great if you could review this PR as well. |
|
@k163377 👍 Will do, thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
The main purpose of this PR is to speed up the
AnnotatedMethod.hasRequiredMarkermethod.On getting a
RequiredMarkerfrom aKPropertyThe process of getting
RequiredMarkerfromKPropertyhas been modified to be done in a single loop.In the current implementation, the process of getting the
RequiredMarkerfromKPropertyis performed separately byAnnotatedMethod.getCorrespondingGetterandAnnotatedMethod.getCorrespondingSetter.member.declaringClass.kotlin.declaredMemberProperties, which is called in each of these two methods, is considered to be expensive to execute (I didn't run a benchmark to confirm this, but it seems so from the implementation).Therefore, reducing the number of calls to it will speed up the process.
Regarding
KFunction<*>.isSetterLike()Since the result of
Unit::class.createType()executed byKFunction<*>.isSetterLike()is immutable, it has been modified to be used as a constant.This process also seems to have been expensive to execute.
Others
I also did some refactoring at the same time.
Questions
Should
declaringClass.kotlin.declaredMemberPropertiesalso be cached asClass->List<KProperty1>?When serializing/deserializing a class with a large number of fields, it seems to be more efficient to cache this process as well.