Fix JacksonInject priority #738
Merged
+41
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
commented
Dec 9, 2023
|
|
||
| val paramType = paramDef.type | ||
| var paramVal = if (!isMissing || paramDef.isPrimitive() || jsonProp.hasInjectableValueId()) { | ||
| var paramVal = if (!isMissing || jsonProp.hasInjectableValueId()) { |
There was a problem hiding this comment.
Removed the decision because jsonProp.valueDeserializer?.getAbsentValue(ctxt) provides the same functionality as this branch.
The following test confirms that it fails if FAIL_ON_NULL_FOR_PRIMITIVES is set.
https://github.com/FasterXML/jackson-module-kotlin/pull/738/files#diff-d8cb2007657572bfaed68d85f55829d211695e1f181981499dcb6a3a72516472
k163377
added a commit
to k163377/jackson-module-kotlin
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #722