Backport #3419 change to 2.13(.3)

Author: cowtowncoder

release-notes/VERSION-2.x

@@ -6,6 +6,9 @@ Project: jackson-databind
 
 2.13.3 (not yet released)
 
+#3419: Improve performance of `UnresolvedForwardReference` for forward
+ reference resolution
+(contributed by Gary M)
 #3446: `java.lang.StringBuffer` cannot be deserialized
  (reported by Lolf1010@github)
 

src/main/java/com/fasterxml/jackson/databind/deser/DefaultDeserializationContext.java

@@ -168,7 +168,8 @@ public void checkUnresolvedObjectId() throws UnresolvedForwardReference
                 continue;
             }
             if (exception == null) {
-                exception = new UnresolvedForwardReference(getParser(), "Unresolved forward references for: ");
+                exception = new UnresolvedForwardReference(getParser(), "Unresolved forward references for: ")
+                        .withStackTrace();
             }
             Object key = roid.getKey().key;
             for (Iterator<Referring> iterator = roid.referringProperties(); iterator.hasNext(); ) {

src/main/java/com/fasterxml/jackson/databind/deser/UnresolvedForwardReference.java

@@ -97,4 +97,29 @@ public String getMessage()
         sb.append('.');
         return sb.toString();
     }
+
+    /**
+     * This method is overridden to prevent filling of the stack trace when
+     * constructors are called (unfortunately alternative constructors can
+     * not be used due to historical reasons).
+     * To explicitly fill in stack traces method {@link #withStackTrace()}
+     * needs to be called after construction.
+     *
+     * @since 2.14
+     */
+    @Override
+    public synchronized UnresolvedForwardReference fillInStackTrace() {
+        return this;
+    }
+
+    /**
+     * "Mutant" factory method for filling in stack trace; needed since the default
+     * constructors will not fill in stack trace.
+     *
+     * @since 2.14
+     */
+    public UnresolvedForwardReference withStackTrace() {
+        super.fillInStackTrace();
+        return this;
+    }
 }