Remove SealEpochRewards treasury transfer status check (#89)

Mike-CZ · web-flow · commit 5be77a567dd9 · 2024-11-04T09:24:45.000+01:00
* Add docs for `SFC` contract

* Fix lint warnings

* Fix comments

* Remove `SealEpochRewards` transfer status check

* Fix solhint warning

* Fix typo

* Update comment
diff --git a/contracts/sfc/SFC.sol b/contracts/sfc/SFC.sol
@@ -932,8 +932,10 @@ contract SFC is Initializable, Ownable, Version {
             uint256 feeShare = (ctx.epochFee * c.treasuryFeeShare()) / Decimal.unit();
             _mintNativeToken(feeShare);
             (bool success, ) = treasuryAddress.call{value: feeShare, gas: 1000000}("");
+            // solhint-disable-next-line no-empty-blocks
             if (!success) {
-                revert TransferFailed();
+                // ignore treasury transfer failure
+                // the treasury failure must not endanger the epoch sealing
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -932,8 +932,10 @@ contract SFC is Initializable, Ownable, Version {`
`932`	`932`	`uint256 feeShare = (ctx.epochFee * c.treasuryFeeShare()) / Decimal.unit();`
`933`	`933`	`_mintNativeToken(feeShare);`
`934`	`934`	`(bool success, ) = treasuryAddress.call{value: feeShare, gas: 1000000}("");`
	`935`	`+ // solhint-disable-next-line no-empty-blocks`
`935`	`936`	`if (!success) {`
`936`		`- revert TransferFailed();`
	`937`	`+ // ignore treasury transfer failure`
	`938`	`+ // the treasury failure must not endanger the epoch sealing`
`937`	`939`	`}`
`938`	`940`	`}`
`939`	`941`	`}`