space age solar panels

[ahicks92]

We have a hardcoded formula in at least two places:

cap_add = cap_add * ent.surface.solar_power_multiplier * (1 - ent.surface.darkness)

And also:

local function ent_info_solar(ctx)
   local ent = ctx.ent

   if ent.type == "solar-panel" then
      local s_time = ent.surface.daytime * 24 --We observed 18 = peak solar start, 6 = peak solar end, 11 = night start, 13 = night end
      local solar_status = ""
      if s_time > 13 and s_time <= 18 then
         ctx.message:fragment({ "fa.ent-info-solar-increasing" })
      elseif s_time > 18 or s_time < 6 then
         ctx.message:fragment({ "fa.ent-info-solar-full-production" })
      elseif s_time > 6 and s_time <= 11 then
         ctx.message:fragment({ "fa.ent-info-solar-evening" })
      elseif s_time > 11 and s_time <= 13 then
         ctx.message:fragment({ "fa.ent-info-solar-night" })
      end
   end
end

I believe the first formula may be correct. I believe we may be able to just check if darkness = 00.0 or 1.0. But the second isn't going to work on any other planet but Nauvis for suer, and the first needs to at least account for solar multipliers and maybe more.

[LevFendi]

Surface darkness would almost certainly work better than hardcoding.

[ahicks92]

Someone needs to check that it doesn't linearly increase/decrease beyond the point where solar panels hit their max.