Some API changes

Author: NebelNidas

CHANGELOG.md

@@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Made `OuterClassNamePropagator` configurable
 - Made Enigma writer always output destination names if visited explicitly, establishing consistency across all writers
 - Added a simplified `MappingNsCompleter` constructor for completing all destination names with the source names
-- Added translatable `MappingFormat#getName()`
+- Added `MappingFormat#translatableName()`
 
 ## [0.7.1] - 2025-01-07
 - Restored the ability to read source-namespace-only mapping files, even if not spec-compliant

src/main/java/net/fabricmc/mappingio/format/MappingFormat.java

@@ -24,7 +24,6 @@
 import net.fabricmc.mappingio.format.FeatureSet.FeaturePresence;
 import net.fabricmc.mappingio.format.FeatureSet.MetadataSupport;
 import net.fabricmc.mappingio.i18n.Translatable;
-import net.fabricmc.mappingio.i18n.TranslatableImpl;
 
 /**
  * Represents a supported mapping format. Every format can be assumed to have an associated reader available.
@@ -281,7 +280,7 @@ public enum MappingFormat {
 
 	MappingFormat(@Nullable String fileExt, boolean hasWriter, FeatureSetBuilder featureBuilder) {
 		this.translationKey = "format." + name().toLowerCase(Locale.ROOT);
-		this.name = getName().translate(Locale.US);
+		this.name = translatableName().translate(Locale.US);
 		this.fileExt = fileExt;
 		this.hasWriter = hasWriter;
 		this.features = featureBuilder.build();
@@ -292,8 +291,8 @@ public enum MappingFormat {
 		this.supportsLocals = features.supportsVars();
 	}
 
-	public Translatable getName() {
-		return new TranslatableImpl(translationKey);
+	public Translatable translatableName() {
+		return Translatable.of(translationKey);
 	}
 
 	public FeatureSet features() {
@@ -314,7 +313,7 @@ public String getGlobPattern() {
 	private final String translationKey;
 	private final FeatureSet features;
 	/**
-	 * @deprecated Use {@link #getName()} instead.
+	 * @deprecated Use {@link #translatableName()} instead.
 	 */
 	@Deprecated
 	public final String name;

src/main/java/net/fabricmc/mappingio/i18n/Translatable.java

@@ -22,6 +22,11 @@
 
 @ApiStatus.NonExtendable
 public interface Translatable {
+	@ApiStatus.Internal
+	static Translatable of(String translationKey) {
+		return new TranslatableImpl(translationKey);
+	}
+
 	/**
 	 * Translates this translatable to the specified locale, with a fallback to en_US.
 	 */

src/main/java/net/fabricmc/mappingio/i18n/TranslatableImpl.java

@@ -18,11 +18,8 @@
 
 import java.util.Locale;
 
-import org.jetbrains.annotations.ApiStatus;
-
-@ApiStatus.Internal
-public final class TranslatableImpl implements Translatable {
-	public TranslatableImpl(String translationKey) {
+final class TranslatableImpl implements Translatable {
+	TranslatableImpl(String translationKey) {
 		this.translationKey = translationKey;
 	}
 

src/test/java/net/fabricmc/mappingio/test/tests/i18n/I18nTest.java

@@ -54,11 +54,11 @@ public static void init() throws Exception {
 	@SuppressWarnings("deprecation")
 	public void mappingFormatNames() {
 		for (MappingFormat format : MappingFormat.values()) {
-			String enUsName = format.getName().translate(Locale.US);
+			String enUsName = format.translatableName().translate(Locale.US);
 			assertEquals(enUsName, format.name);
 
 			for (Locale locale : supportedLocales) {
-				String translatedName = format.getName().translate(locale);
+				String translatedName = format.translatableName().translate(locale);
 				assertFalse(translatedName.startsWith("format."), "Translated name for " + format + " in " + locale + " is missing");
 			}
 		}