Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Invalidation: RemoveCode shouldn't free IRLists, as that breaks self-invalidation in interpreter #808

Open
skmp opened this issue Feb 26, 2021 · 0 comments
Assignees
Milestone

Comments

@skmp
Copy link
Contributor

skmp commented Feb 26, 2021

Follow up from #705

If the interpreter invalidates (either via syscall, or op_removecodeentry) it needs to run the current block to the block exit. We should "stage" removed code blocks to a "to free" list, and GC them at a point where we're sure we're not running them.

This doesn't affect the jit as it doesn't reference the ir data during runtime

@skmp skmp modified the milestones: 2210, 2209 Aug 10, 2022
@skmp skmp self-assigned this Aug 10, 2022
@skmp skmp moved this to 🆕 New in Next Project Milestone Aug 18, 2022
@skmp skmp moved this from 🆕 Unplanned to 📋 Current Release in Next Project Milestone Aug 18, 2022
@skmp skmp moved this from 📋 Current Milestone to ⚡ Quickies in Next Project Milestone Aug 18, 2022
@skmp skmp moved this from ⚡ Quickies to 🧠 Conceptual in Next Project Milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧠 Conceptual
Development

No branches or pull requests

1 participant