Cached predicate register being clobbered by softfp lib call #4264
Comments
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 10, 2025
This reverts commit 72a4063. Caused FEX-Emu#4264
pmatos
changed the title
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 13, 2025
Whenever the control float leaves the block, it might clobber the predicate register so we reset the cache whenever that happens. The difficulty here is that the cache is valid only during IR generation so we need to make sure we catch all the cases during this pass where the execution might leave the block. Fixes FEX-Emu#4264
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 13, 2025
Whenever the control float leaves the block, it might clobber the predicate register so we reset the cache whenever that happens. The difficulty here is that the cache is valid only during IR generation so we need to make sure we catch all the cases during this pass where the execution might leave the block. Fixes FEX-Emu#4264
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 13, 2025
Whenever the control float leaves the block, it might clobber the predicate register so we reset the cache whenever that happens. The difficulty here is that the cache is valid only during IR generation so we need to make sure we catch all the cases during this pass where the execution might leave the block. Fixes FEX-Emu#4264
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 15, 2025
Whenever the control float leaves the block, it might clobber the predicate register so we reset the cache whenever that happens. The difficulty here is that the cache is valid only during IR generation so we need to make sure we catch all the cases during this pass where the execution might leave the block. Fixes FEX-Emu#4264
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 15, 2025
Whenever the control float leaves the block, it might clobber the predicate register so we reset the cache whenever that happens. The difficulty here is that the cache is valid only during IR generation so we need to make sure we catch all the cases during this pass where the execution might leave the block. Fixes FEX-Emu#4264
pmatos
added a commit
to pmatos/FEX
that referenced
this issue
Jan 16, 2025
Whenever the control float leaves the block, it might clobber the predicate register so we reset the cache whenever that happens. The difficulty here is that the cache is valid only during IR generation so we need to make sure we catch all the cases during this pass where the execution might leave the block. Fixes FEX-Emu#4264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunately, the code to cache predicate registers for SVE x87 ldst optimization and the precision tests that do a bunch of:
were developed at a similar time and landed more of less at a similar time. We might not have SVE hw in CI and I didn't test this until now. The culprit commit is 72a4063 . What's happening is that in this specific case we are caching p2, calling softfp fcos impl which clobbers p2 and its use in fstp causes the bug - i.e. the test to fail.
The text was updated successfully, but these errors were encountered: