Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate unit tests for LOCK ops that touch flags #1164

Open
Sonicadvance1 opened this issue Jul 13, 2021 · 0 comments
Open

Generate unit tests for LOCK ops that touch flags #1164

Sonicadvance1 opened this issue Jul 13, 2021 · 0 comments
Milestone
2212

Comments

@Sonicadvance1
Copy link
Member

We currently don't have unit tests that for LOCK operations and flag setting.
We hit a bug that these weren't generating flags correctly that went unnoticed.
Sonicadvance1 added a commit to Sonicadvance1/FEX that referenced this issue Jul 13, 2021
@Sonicadvance1
Fixes flag setting for 8bit and 16bit LOCK ALU ops
0ade576 
MUL is handled in a different function, so this isn't needed there anymore.
This was causing a problem where if you force enabled LOCK on all capable ops it was causing a crash.

Issue FEX-Emu#1164 is set to track getting unit tests for these.
@Sonicadvance1 Sonicadvance1 mentioned this issue Jul 13, 2021
Merged
@skmp skmp added this to the 2212 milestone Aug 10, 2022
@skmp skmp moved this to 🆕 Unplanned in Next Project Milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Next Project Milestone
Status: 🆕 Unschedulled
Milestone
2212
Development

No branches or pull requests
2 participants
@skmp @Sonicadvance1