ISerializer<CustomInheritedClass>

[miliante]

Thank you for the wonders of ExtendedXmlSerializer. I solved many problems (but sometimes it is difficult to find updated docs)

I have classes/interface as follows (to avoid excess code I put only the header of the classes/interface):

public interface IDataElement;
public class ClsArray : ExtendedList<ClsRecord>, IDataElement;
public class ClsItem : IDataElement

when I create a custom public class ClsItemSerializer : ISerializer<ClsItem> for deserialization and register:

            return new ConfigurationContainer()
            .EnableImplicitTyping(typeof(ClsDataRoot), typeof(ClsItem), typeof(ClsArray))
            .Type<ClsItem>().Register().Serializer().Using(new ClsItemSerializer()) //.CustomSerializer(new ClsItemSerializer())
            .Create();

Both ClsArray and ClsItem are caught in the Get method of the custom serializer. Why not only ClsItem? I made some tests and I believe it is because of the interface that is shared by both. But I must keep it as is to allow me to have these classes in the same List. How could I overcome this?

[Mike-E-angelo]

Hi @miliante thank you for your kind words and for writing in. 🙏

I unfortunately could not reproduce your problem. There are a few types listed above that do not compile so I had to make placeholders to do so. Here is the test as I am running it. Please modify and provide the necessary changes to fail (or to break at line 33 in the Get) and I will further investigate for you. 👍

public sealed class Issue657Tests
{
	[Fact]
	public void Verify()
	{
		var subject = new ConfigurationContainer()
		       .EnableImplicitTyping(typeof(ClsItem), typeof(ClsArray))
		       .Type<ClsItem>().Register().Serializer().Using(new ClsItemSerializer()) //.CustomSerializer(new ClsItemSerializer())
		       .Create().ForTesting();

		var instance = new ClsArray();
		subject.Cycle(instance).Should().BeEquivalentTo(instance);

	}

	public interface IDataElement;
	public class ClsArray : List<ClsRecord>, IDataElement;
	public class ClsRecord {}
	public class ClsItem : IDataElement;

	public class ClsItemSerializer : ISerializer<ClsItem>
	{
		public ClsItem Get(IFormatReader parameter) => new();

		public void Write(IFormatWriter writer, ClsItem instance) {}
	}
}

[miliante]

Hello,
My apologies, my case was too complex to summarize only with the headers for the classes likeI did.
I am not good with UnitTests, but I am good with breakpoints. In the code below I registered a serializer for ClsItem, but I believe that because IDataElement is shared between ClsItem and ClsArray, the custom serializer is called for both functions. If I remove the implementation of IDataElement in ClsItem it works as expected.
The figure shows that when I inspect the code, the array is called...

Thank you for your help :)

using ExtendedXmlSerializer;
using ExtendedXmlSerializer.Configuration;
using ExtendedXmlSerializer.ContentModel;
using ExtendedXmlSerializer.ContentModel.Format;

using System.Xml.Serialization;

using XmlDataIO;

namespace Text;
public sealed class Issue657Tests
{
    public static void Verify()
    {

        var xml = @"
          <main teste=""teste-1"">
            <array dataname=""compartments"">
                <item dataname=""tank"">12</item>
            </array>
            <main>
        ";

        IExtendedXmlSerializer subject = new ConfigurationContainer()
               .EnableImplicitTyping(typeof(ClsRoot),typeof(ClsItem), typeof(ClsArray))
               .Type<ClsItem>().Register().Serializer().Using(new ClsItemSerializer())
               .Create();


        ClsRoot root = subject.Deserialize<ClsRoot>(xml);


    }

    public class ClsItemSerializer : ISerializer<ClsItem>
    {
        public ClsItem Get(IFormatReader parameter)
        {

            return new();
        }

        public void Write(IFormatWriter writer, ClsItem instance) { }
    }
}

public interface IDataElement
{
    string Dataname { get; set; }
}

[XmlRoot("main")]
public class ClsRoot : List<IDataElement>
{

}
[XmlType("array")]
public class ClsArray : List<ClsItem>, IDataElement
{
    public string Dataname { get ; set; }
}
[XmlType("item")]
public class ClsItem : IDataElement
{
    public string Dataname { get; set; }
}

internal class MainClass
{
    public static void Main()
    {
        Issue657Tests.Verify();
    }

}

[create-issue-branch]

Branch issues/fix/i657 created!

[Mike-E-angelo]

Hi @miliante thank you for your additional context it is appreciated. And no worries about figuring out what is happening here. As I like to say there are many moving pieces in life, particularly in learning something new. 🙏

And indeed, you found a problem in how our custom serializers are selected. They were being considered for any implemented types, which doesn't make sense in this case. I have committed a fix and you are free to try it out here:

#658 (comment)

Once you have verified on your end I will push this to NuGet. 👍

[miliante]

Thank you @Mike-E-angelo, that was fast. Fortunately, learning is the best part :)
I will try it out later today and get back to you.

[miliante]

It is working perfectly! Thank you again for your support and the development of this tool :)

[Mike-E-angelo]

Thank you for the kind words and confirmation @miliante 🙏 I have pushed this to NuGet and it should be available in a few minutes (but up to 30 worst case).

[miliante]

Hello again,
My apologies for reopening the ticket, but after I ran with the updated custom serializer i had problems with ClsItem nodes that were empty in the xml file, i.e., . The parent node (array) was having its dataname overwrittev with the last item's empty node's dataname for some reason.

In this example, the instances were as follow
var xml = @"
<main teste=""teste-1"">
<array dataname=""compartments"">
<item dataname=""tank"">12
<item dataname=""bottle""/>

";
Variable | Value
main.test => "teste-1"
array.dataname => "bottle" (instead of array.dataname => "compartments")
item1.dataname => "tank", item1.Content => "12"
item2.dataname => "bottle", item2.Content => ""

To fix in my computer I did change the XmlContent.cs file, by adding an "Empty test", as follows:

namespace ExtendedXmlSerializer.ExtensionModel.Xml
{
	readonly struct XmlContent
	{
		readonly XmlAttributes? _attributes;
		readonly XmlElements?   _elements;

		public XmlContent(XmlAttributes? attributes, XmlElements? elements)
		{ 
			_attributes = attributes;
			_elements   = elements;
        }

        public bool MoveNext()
		{
			var attributes = _attributes;
			var content    = _elements;
            var result =  !(content?.IsEmpty() ?? false) ? (attributes?.MoveNext() ?? false) || (content?.MoveNext() ?? false) : (content?.MoveNext() ?? false);
            return result;
        }

		public object Current => null;
	}
}

I also added the following method to the XmlElements.cs
public bool IsEmpty() => _reader.IsEmptyElement;

It may not be necessary, and there may be another solution.
Feel free to close this ticket :)

Thank you!

[Mike-E-angelo]

Heya @miliante thank you for your continued dialogue, it is appreciated. 🙏

For this issue, I wanted to make sure about something before we continue. The XML does not appear to be well-formed:

<main teste=""teste-1"">
<array dataname=""compartments"">
<item dataname=""tank"">12
<item dataname=""bottle""/>

1. The <main> element is not closed
2. The <array> element is not closed
3. The <item> with the name tank is not closed
4. There is an orphaned value of 12

All of these will lead to a broken graph. I am surprised you are not seeing additional errors than the one you are seeing. Please make sure the XML is well-formed and see if that fixes your issue. Otherwise we can continue here. 👍