[Due for payment 2025-04-02] [$250] Distance - Zero amount not displayed in receipt and expense details for distance expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: V9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Go to workspace settings > enable distance rate
3. Change the rate to 0.0001
4. Go to workspace chat
5. Create a distance expense with following way points 65, pappammal koil, vaithikuppam, puducherry, India & 67, pappammal koil, vaithikuppam, puducherry, India
6. Note in confirmation page and in expense preview ₹0.00 amount is shown
7. Open the expense
8. Tap the receipt
9. Note amount zero is not shown and in receipt also no details about amount

Expected Result:

The confirmation page, expense preview, and receipt should consistently display amount ₹0.00 .

Actual Result:

In the confirmation page and expense preview, ₹0.00 is displayed.

After opening the expense and tapping the receipt, the amount is not shown, and the receipt lacks any details about the amount.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6770462_1741942910940.Screenrecorder-2025-03-14-14-18-57-910.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021900601730914519131
• Upwork Job ID: 1900601730914519131
• Last Price Increase: 2025-03-14

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[ryntgh]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-17 07:26:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Zero amount not displayed in receipt and expense details for distance expense

What is the root cause of that problem?

The component conditionally renders the transaction amount using a falsy check ({!!transactionAmount}), which evaluates to false when the amount is 0. This causes 0 (a valid value) not to be displayed.

App/src/components/DistanceEReceipt.tsx

Line 69 in 06abee6

{!!transactionAmount && <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>}

Additionally, in MoneyRequestView, the amount formatting logic also uses a falsy check (transactionAmount ? ... : ''), which results in 0 being replaced with an empty string.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 159 to 160 in 06abee6

	const formattedTransactionAmount = transactionAmount ? convertToDisplayString(transactionAmount, transactionCurrency) : '';
	const formattedPerAttendeeAmount = transactionAmount ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency) : '';

What changes do you think we should make in order to solve the problem?

We should update the conditional check to ensure that the amount is displayed even when it is 0. For example, we can change the condition to verify that the amount is not null or undefined:

{(transactionAmount !== null && transactionAmount !== undefined) && (
    <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>
)}

Or, alternatively:

{(transactionAmount || transactionAmount === 0) && (
    <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>
)}

For MoneyRequestView:

    const formattedTransactionAmount = transactionAmount !== null && transactionAmount !== undefined ? convertToDisplayString(transactionAmount, transactionCurrency) : '';
    const formattedPerAttendeeAmount = transactionAmount !== null && transactionAmount !== undefined ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency) : '';

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A, minor UI bug

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021900601730914519131

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-17 06:24:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the confirmation page and expense preview, ₹0.00 is displayed.

What is the root cause of that problem?

In the expense preview, we always display the formatted amount string without any condition

But in DistanceEReceipt, the amount is only displayed if transactionAmount isn't 0, undefined, null.

App/src/components/DistanceEReceipt.tsx

Line 69 in 6d00a6b

{!!transactionAmount && <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>}

The same bug happens on MoneyRequestView,

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 159 to 160 in 703cdf4

	const formattedTransactionAmount = transactionAmount ? convertToDisplayString(transactionAmount, transactionCurrency) : '';
	const formattedPerAttendeeAmount = transactionAmount ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency) : '';

What changes do you think we should make in order to solve the problem?

1. We can remove this condition

{<Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>}

App/src/components/DistanceEReceipt.tsx

Line 69 in 6d00a6b

{!!transactionAmount && <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>}

2. For the MoneyRequestView, we need to check the distance request has a route or not before displaying the amount, because if the route is pending, the amount isn't calculated and it's 0 by default

const formattedTransactionAmount = (!!transactionAmount || (isDistanceRequest && hasRoute)) ? convertToDisplayString(transactionAmount, transactionCurrency) : '';
const formattedPerAttendeeAmount = (!!transactionAmount || (isDistanceRequest && hasRoute)) ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency) : '';

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 159 in 703cdf4

const formattedTransactionAmount = transactionAmount ? convertToDisplayString(transactionAmount, transactionCurrency) : '';

Note: For the DistanceEReceipt we don't need to check the condition like this because the DistanceEReceipt is only displayed when the route exists, that means the amount is already calculated.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is an UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[utkershrajvenshi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In distance expenses, zero amount is not displayed in receipt and expense details

What is the root cause of that problem?

We are checking if transactionAmount is a valid, defined value in MoneyRequestView.tsx:

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 159 to 160 in 3ca6a25

	const formattedTransactionAmount = transactionAmount ? convertToDisplayString(transactionAmount, transactionCurrency) : '';
	const formattedPerAttendeeAmount = transactionAmount ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency) : '';

and in DistanceEReceipt.tsx:

App/src/components/DistanceEReceipt.tsx

Line 69 in 3ca6a25

{!!transactionAmount && <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>}

The checks are failing for transactionAmount with value 0 due to being inferred as a falsy value.

What changes do you think we should make in order to solve the problem?

We can explicitly check if transactionAmount is undefined in these places:

const formattedTransactionAmount = transactionAmount !== undefined ? convertToDisplayString(transactionAmount, transactionCurrency) : '';
const formattedPerAttendeeAmount = transactionAmount !== undefined ? convertToDisplayString(transactionAmount / (transactionAttendees?.length ?? 1), transactionCurrency) : '';

{transactionAmount !== undefined && <Text style={styles.eReceiptAmount}>{formattedTransactionAmount}</Text>}

This allows cases where transactionAmount is 0 to pass the checks and render values correctly:

In MoneyRequestView	In DistanceERecipt

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[nkdengineer]

Updated proposal.

[Ollyws]

This one is pretty straightforward and @ryntgh's is the first proposal that does the job so let's go with that.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkdengineer]

For the MoneyRequestView, we need to check the distance request has a route or not before displaying the amount, because if the route is pending, the amount isn't calculated and it's 0 by default

@Ollyws Can you check the point I mentioned for the case of MoneyRequestView

[melvin-bot]

📣 @ryntgh You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@Ollyws Please help to check my comment before moving this forward.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Zero amount not displayed in receipt and expense details for distance expense #58649

If no regressions arise, payment will be issued on 2025-04-02. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @ryntgh requires payment (Needs manual offer from BZ)

[melvin-bot]

@Ollyws @lschurr @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[lschurr]

@Ollyws could you complete the checklist?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @Ollyws owed $250 via NewDot
• Contributor: @ryntgh $250 (offer sent in Upwork)

BugZero Checklist (@lschurr)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1900601730914519131/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Ollyws]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user

• 3b. Expensify employee

• 3c. Contributor

• 3d. QA

• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: The only chages to the related front-end code were made over a year ago, so I assume this one must have been caused by a back-end change.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Go to workspace settings > enable distance rate
2. Change the rate to 0.0001
3. Go to workspace chat
4. Create a distance expense with the following waypoints:
5. 65, Pappammal Koil, Vaithikuppam, Puducherry, India & 67, Pappammal Koil, Vaithikuppam, Puducherry, India.
6. Note in confirmation page and in expense preview 0.00 amount is shown
7. Open the expense
8. Verify that the amount displayed on MoneyRequestView is 0.00
9. Tap the receipt
10. Verify that the receipt displays 0.00 as the amount

Do we agree 👍 or 👎

[Ollyws]

Requested in ND.

[lschurr]

@ryntgh - Offer sent in Upwork: https://www.upwork.com/nx/wm/offer/106763920

[ryntgh]

@lschurr Offer accepted