Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No BZ] Set up MiniFlare for local development + external contributors #38072

Open
roryabraham opened this issue Mar 11, 2024 · 31 comments
Open
Assignees
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Not a priority

Comments

@roryabraham
Copy link
Contributor

Coming from this old WN post and this comment...

Problem

We don't currently have an obvious setup to test the CSP locally. As a result, we only ever find CSP issues on staging, and at that point they are deploy blockers.

Solution

Open-source the NewDot CSP(s) and set up MiniFlare for local testing.

@roryabraham roryabraham added Monthly KSv2 NewFeature Something to build that is a new item. labels Mar 11, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

@melvin-bot melvin-bot bot added the Weekly KSv2 label Mar 11, 2024
Copy link

melvin-bot bot commented Mar 11, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@melvin-bot melvin-bot bot removed the Monthly KSv2 label Mar 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 19, 2024
@justinpersaud
Copy link
Contributor

No update yet, working on SMS related issues

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@justinpersaud
Copy link
Contributor

Same ☝🏽

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@mallenexpensify
Copy link
Contributor

@justinpersaud the BugZero team is adding all E/App issues with the Bug or NewFeature label to a project. This one is kinda lingering. It will surface each week as part of the #expensify-open-source weekly update. Trying to think how best to handle.

  1. Add a BZ and add to a project
  2. Remove NewFeature
  3. Preface title with [No BZ] to denote it's not a normal feature request or bug
  4. Something else.

Any thoughts/preferances?

@justinpersaud
Copy link
Contributor

2 or 3 probably work. This is sort of a long standing issue we've had since basically the inception of NewDot. It's something we should do, and nice to do, but I don't know that it takes priority over one of our upcoming releases or waves.

@mallenexpensify
Copy link
Contributor

Thanks @justinpersaud . I'm torn between 2 and 3 but, I imagine there'll be other instances where it makes sense to have NewFeature without it needing a BZ so I'm going to go with #3. I'll update the SO to state

@mallenexpensify mallenexpensify changed the title Set up MiniFlare for local development + external contributors [No BZ] Set up MiniFlare for local development + external contributors Apr 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2024
@justinpersaud
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 23, 2024
@justinpersaud
Copy link
Contributor

Same

@melvin-bot melvin-bot bot removed the Overdue label Apr 26, 2024
@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
@justinpersaud
Copy link
Contributor

Nothing new here

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@roryabraham
Copy link
Contributor Author

I managed to get a Miniflare instance running and to work around this issue by prepending the command with NODE_EXTRA_CA_CERTS="" like so:

NODE_EXTRA_CA_CERTS="" npx wrangler dev index.js

@melvin-bot melvin-bot bot removed the Overdue label Aug 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2024
@roryabraham
Copy link
Contributor Author

no update

@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 13, 2024
@justinpersaud
Copy link
Contributor

Still no update

@melvin-bot melvin-bot bot removed the Overdue label Sep 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@justinpersaud
Copy link
Contributor

Nothing on my end

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2024
@roryabraham
Copy link
Contributor Author

Headed on parental leave, unassigning. Still think it would be a nice-to-have to make our dev environment more similar to the production environment, but I agree it's not an urgent priority.

@roryabraham roryabraham removed their assignment Oct 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@justinpersaud justinpersaud added Monthly KSv2 and removed Weekly KSv2 labels Oct 15, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
@justinpersaud
Copy link
Contributor

Not a priority right now

@justinpersaud
Copy link
Contributor

Still not a priority

@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 21, 2025
@justinpersaud
Copy link
Contributor

Going to remove assignment because I haven't had a chance to work on this for many months now

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2025
@justinpersaud justinpersaud removed their assignment Jan 22, 2025
@roryabraham roryabraham self-assigned this Jan 27, 2025
@roryabraham
Copy link
Contributor Author

@arosiclair got this working on his laptop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 NewFeature Something to build that is a new item. Not a priority
Projects
None yet
Development

No branches or pull requests

5 participants