Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feature Electron App #20

Closed
krrprr opened this issue Oct 22, 2020 · 7 comments
Closed

Update Feature Electron App #20

krrprr opened this issue Oct 22, 2020 · 7 comments
Assignees
Labels
P2 mid priority
Milestone

Comments

@krrprr
Copy link
Contributor

krrprr commented Oct 22, 2020

Enable updating the application without manually downloading and installing a new version.

@kilrau
Copy link
Contributor

kilrau commented Oct 22, 2020

Recap: idea is to use https://github.com/vercel/hazel for Win & Mac, for Linux just show the update notification with download button because there is no standardized way to load updates yet.

@kilrau kilrau added the P2 mid priority label Oct 22, 2020
@kilrau kilrau added this to the v1.5.0 milestone Oct 26, 2020
@kilrau
Copy link
Contributor

kilrau commented Nov 5, 2020

Two things to update:

  1. Electron App: display there is an app update, offer installation (see wireframe) - this is what this issue is about
  2. Docker update: trigger accepting docker update prompt via api for local & remote environments: Update Feature Containers #88

@kilrau kilrau changed the title Create update functionality Update Feature Electron App Nov 5, 2020
@kilrau kilrau modified the milestones: v1.5.0, v1.4.0 Nov 6, 2020
@krrprr
Copy link
Contributor Author

krrprr commented Dec 11, 2020

  1. Docker update: trigger accepting docker update prompt via api for local & remote environments: Update Feature Containers #88

This actually only applies to remote environments. When the electron app is updated, the new launcher version comes with it (in case the new xud-ui version with the latest launcher is released, which should be the practice) and it defines the versions, so there is no need to update the local xud-docker environment separately. When the app is restarted, new containers are pulled and the whole environment gets updated at once.

@kilrau
Copy link
Contributor

kilrau commented Dec 11, 2020

Right. Good.

How could an update of a remote environment work though if I am connecting to it via the Electron App / browser via the build-in web app of the proxy container?

@krrprr
Copy link
Contributor Author

krrprr commented Dec 11, 2020

Right. Good.

How could an update of a remote environment work though if I am connecting to it via the Electron App / browser via the build-in web app of the proxy container?

I think the exact implementation of remote environments should be discussed and/or decided in #88.
The tricky part there is the case when the user connects to a remote environment via the xud-ui app - the versions have to be compatible. Have no plan for this yet.

@krrprr
Copy link
Contributor Author

krrprr commented Dec 14, 2020

Recap: idea is to use https://github.com/vercel/hazel for Win & Mac, for Linux just show the update notification with download button because there is no standardized way to load updates yet.

Seems that https://www.electronjs.org/docs/tutorial/updates#using-updateelectronjsorg would be sufficient instead of hazel. In both ways the code-signing is required at least for macOS.

@kilrau
Copy link
Contributor

kilrau commented Dec 14, 2020

In both ways the code-signing is required at least for macOS.

I am taking care of an Apple developer account today.

@krrprr krrprr closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 mid priority
Projects
None yet
Development

No branches or pull requests

3 participants