Skip to content

Status bar icons invisible in desktop builds (add worksheet, sheet list, zoom +/-) — SVG icon migration misses el-bound buttons #196

Description

@lif9e1

Symptom. In self-built DesktopEditors (macOS arm64 and Windows x64, current main), several spreadsheet status bar buttons render blank while remaining functional (hover tooltips still appear): add worksheet, sheet list, tab prev/next, and zoom +/-.

Root cause. The SVG sprite migration (templateBtnIcon in apps/common/main/lib/component/Button.js) emits <svg><use href="#btn-x"> only when a button renders its own template. Buttons bound to pre-existing markup via the el option — e.g. everything in apps/spreadsheeteditor/main/app/template/StatusBar.template — never run the template, so their static <i class="icon toolbar__icon btn-*"> markup survives. The CSS sprite classes that markup relied on no longer exist in the built app.css, leaving functional but invisible buttons. Any el-bound button with static <i> icons in any editor is affected.

Fix. The linked PR converts those static icons in render() the same way the template does (same /btn-[^\s]+/ extraction, fragment-only <use> references). Verified on macOS and Windows desktop builds: all status bar icons render again; add/list/zoom behaviors unchanged.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions