Skip to content

PUBLISHER_NAME defaults to Ascensio branding in shipped build output #40

Description

@moodyjmz

Problem

Makefile defaults PUBLISHER_NAME ?= Ascensio System SIA (line 9), passed into GRUNT_ENV (line 14). No override was found anywhere in the actual build pipeline in the sibling repos either (web-apps's docker-bake.hcl/Dockerfile, top-level orchestration Makefiles).

Net effect: unless something outside this repo sets PUBLISHER_NAME at build time, shipped build output defaults to Ascensio branding.

Why this is separate from the web-apps header-comment fix

Euro-Office/web-apps#186 (fixed in web-apps#191) was a header-comment fix — swapping misattributed copyright comments in files with zero ONLYOFFICE authorship. This is a different, higher-risk problem: it's a runtime default that ships to users, and it spans repos.

Target state

Euro-Office/sdkjs#65 (sdkjs's webpack migration, unmerged as of writing) already defaults COMPANY_NAME to 'Euro-Office' and PUBLISHER_URL to https://github.com/Euro-Office/ in its own build. Whoever picks this up should match those values exactly rather than choosing independently.

Scope note

Euro-Office/web-apps (build/theme.config.mjs) and Euro-Office/sdkjs (Makefile, also derives APP_COPYRIGHT from this) have the identical default. Matching issues are being filed there (web-apps#192, sdkjs#72). Needs an actual build to verify before merging, not just a code read — and none of the three should merge independently while the same default is still live elsewhere.

Related: Euro-Office/web-apps#192, Euro-Office/sdkjs#72.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions