Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out the code for Limit how many rows show in the related table for R1 #1141

Open
skrishn opened this issue Jan 30, 2025 · 2 comments
Assignees

Comments

@skrishn
Copy link
Collaborator

skrishn commented Jan 30, 2025

This issue has been moved to R2 by IA team but we have implemented it. @jmhauck pls uncomment this code for R1.

@skrishn skrishn changed the title Comment out the for Limit how many rows show in the related table for R1 Comment out the code for Limit how many rows show in the related table for R1 Jan 30, 2025
@jmhauck
Copy link
Collaborator

jmhauck commented Jan 30, 2025

@skrishn just to double check...right now we should never see the values truncated and using the ellipses at the end?

@sumitzarkar
Copy link
Collaborator

@jmhauck @skrishn

We have added property showFullCommentTitle to reporter to support #1030 . And, this property is set to true by default to support backward compatibility.

Commit link for this code -3384911

If Instant app team have moved the configurtion implementation to next release we still don't have to do any changes as our code will show full comment to support backward compatibility.

When the configuration will be ready and pass the value as false then only ellipses will be shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants