Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch posting delayed because of the frequency of messages #439

Open
Sneh1999 opened this issue Jan 16, 2025 · 1 comment
Open

Batch posting delayed because of the frequency of messages #439

Sneh1999 opened this issue Jan 16, 2025 · 1 comment
Assignees

Comments

@Sneh1999
Copy link

Sneh1999 commented Jan 16, 2025

Issue

The number of messages to be posted in a batch keeps increasing with each iteration, even if an error occurs that prevents the batch from being posted. This poses a problem for us because, in every iteration, we need to post new transactions to Espresso, which take approximately 10 minutes to verify due to the frequency at which the prover posts HotShot state to the light client contract.

Solution

The design needs to be updated so that, during the initial batch posting attempt, we store the last potential message of a batch. This value should remain unchanged in subsequent iterations, even if new messages are added, until the batch is successfully posted.

Testing

  • Add a unit test to test this behaviour
  • Run nitro-testnode to make sure end to end tests are working
  • Test this in SGX to make sure we didnt break anything
@Sneh1999 Sneh1999 self-assigned this Jan 16, 2025
@Sneh1999 Sneh1999 changed the title Batch is not being posted because of the frequency of messages Batch posting delayed because of the frequency of messages Jan 16, 2025
@jbearer
Copy link
Member

jbearer commented Jan 16, 2025

Note that even with the fix this is going to cause an additional 10 minute lag in batch posting compared to the non-Espresso case. With the fix, this lag should not accumulate over time, so batches are still posted every 30 minute interval. But the transactions in a batch will range from 10-40 minutes old, rather than 0-30. This seems fine but just something to keep in mind when we run tests that this is normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants