-
Notifications
You must be signed in to change notification settings - Fork 40
Support Connections in cost complexity calculation #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
This issue is stale because it has been open for 30 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
This issue is stale because it has been open for 30 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The cost complexity
cost-limit
plugin does not take into account how many entities are being returned when either thefirst
orlast
argument are specified at the field level.These two examples which have the same complexity cost (I have omitted
edges
andpageInfo
to keep these examples simple)The cost complexity of this query should increase by a factor of the number of books requested
I have a PR that modifies the
computeComplexity
function inpackages/plugins/cost-limit/src/index.ts/
to factor this in to the complexity cost algorithm.Note the PR does not currently handle
VariableDefinitions
but will handle the example aboveThe text was updated successfully, but these errors were encountered: