Skip to content

[FEATURE] Foundry v13 Support #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
14 of 24 tasks
BoltsJ opened this issue Nov 7, 2024 · 0 comments · May be fixed by #857
Open
14 of 24 tasks

[FEATURE] Foundry v13 Support #773

BoltsJ opened this issue Nov 7, 2024 · 0 comments · May be fixed by #857
Labels
feature New feature or request refactor Refactors of the code base for API changes, maintainability, etc...

Comments

@BoltsJ
Copy link
Collaborator

BoltsJ commented Nov 7, 2024

List of v13 Breaking Changes

So far (as of v13t3):

Appv2 Stuff

  • Update combat tracker sidebar
  • Update combat tracker config extensions (Possibly move the settings to a new location)
  • Update token config extensions
  • Overhaul css to play nice with the new v13 styling
    • Journal styling is broken for dark mode and collapsing the toc permanently hides it
  • (Optional) Per-application theme overrides for system themes
  • Evaluate if the compendium banners need their dimensions adjusted
  • Appv2 hooks recieve an HTMLElement instead of jquery opion
    • Compendium tab button injection
    • Combat tracker config settings injection
    • TokenConfig and PrototypeTokenConfig options injection
    • createChatMessage

API Changes:

  • Evaluate whether builtin TokenDocument#getOccupiedSpacesOffsets can replace custom Token#getOccupiedSpaces
  • {{select}} → {{selectOptions}} in templates
  • Remove custom circle token shape code in favor of native gridless elliptical tokens
    • Ensure that tokens are given a default elliptical shape (override TokenDocument#_initializeSource)
  • TinyMCE → ProseMirror for editors
  • Targeting API change
  • Many things are moving from global to namespaced under foundry

Features

  • CONFIG.queries for socketless cross client communication
  • Disable token image rotation for default retrograde tokens.
  • Provide a custom turn marker image

Bugs

  • Migration hangs in certain scenarios, including the presence of scenes with unlinked tokens.
@BoltsJ BoltsJ added feature New feature or request refactor Refactors of the code base for API changes, maintainability, etc... labels Nov 7, 2024
@Eranziel Eranziel pinned this issue Nov 19, 2024
@BoltsJ BoltsJ linked a pull request Apr 13, 2025 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Refactors of the code base for API changes, maintainability, etc...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant