Skip to content

Commit c817f8a

Browse files
authored
[GHA] Run x86_64 macOS jobs on macOS-13 runners (#765)
* [GHA] Run x86_64 macOS jobs on `macOS-13` runners `macOS-13` is native x86_64 hardware and avoids running through Rosetta, which can lead to nasty test failures. * [GHA] Add timeout for test jobs
1 parent 4ece29d commit c817f8a

File tree

2 files changed

+6
-18
lines changed

2 files changed

+6
-18
lines changed

.github/workflows/CI.yml

+5-18
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ concurrency:
3232

3333
jobs:
3434
test:
35-
name: Julia ${{ matrix.version }} - ${{ matrix.test_group }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ matrix.libReactant }} libReactant - assertions=${{ matrix.assertions }} - ${{ github.event_name }}
35+
timeout-minutes: 90
36+
name: Julia ${{ matrix.version }} - ${{ matrix.test_group }} - ${{ matrix.os }} - ${{ matrix.libReactant }} libReactant - assertions=${{ matrix.assertions }} - ${{ github.event_name }}
3637
runs-on: ${{ matrix.os }}
3738
strategy:
3839
fail-fast: false
@@ -46,63 +47,49 @@ jobs:
4647
# `ubuntu-22.04-arm` is considered more stable than `ubuntu-24.04-arm`:
4748
# <https://github.com/orgs/community/discussions/148648#discussioncomment-12099554>.
4849
- ubuntu-22.04-arm
50+
- macOS-13
4951
- macOS-latest
5052
test_group:
5153
- core
5254
- neural_networks
5355
- integration
54-
arch:
55-
- x64
56-
- aarch64
5756
assertions:
5857
- false
5958
libReactant: [packaged]
6059
include:
6160
- os: ubuntu-24.04
62-
arch: x64
6361
libReactant: packaged
6462
version: '1.10'
6563
assertions: true
6664
test_group: core
6765
- os: ubuntu-24.04
68-
arch: x64
6966
libReactant: packaged
7067
version: '1.10'
7168
assertions: true
7269
test_group: neural_networks
7370
- os: ubuntu-24.04
74-
arch: x64
7571
libReactant: packaged
7672
version: '1.10'
7773
assertions: true
7874
test_group: integration
7975
# - os: ubuntu-24.04
80-
# arch: x86
8176
# libReactant: packaged
8277
# version: '1.10'
8378
# test_group: core
8479
# - os: ubuntu-24.04
85-
# arch: x86
8680
# libReactant: packaged
8781
# version: '1.10'
8882
# test_group: neural_networks
8983
# - os: ubuntu-24.04
90-
# arch: x86
9184
# libReactant: packaged
9285
# version: '1.10'
9386
# test_group: integration
94-
exclude:
95-
- os: ubuntu-24.04 # this is x86_64, exclude foreign architecture
96-
arch: aarch64
97-
- os: ubuntu-22.04-arm # this is aarch64, exclude foreign architecture
98-
arch: x64
9987
steps:
10088
- uses: actions/checkout@v4
10189
- uses: julia-actions/setup-julia@v2
10290
if: ${{ ! matrix.assertions }}
10391
with:
10492
version: ${{ matrix.version }}
105-
arch: ${{ matrix.arch }}
10693
- uses: julia-actions/cache@v2
10794
- uses: actions/checkout@v4
10895
if: ${{ matrix.assertions }}
@@ -117,15 +104,15 @@ jobs:
117104
make -C julia -j $(nproc) FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 JULIA_PRECOMPILE=0
118105
echo $PWD/julia/usr/bin >> $GITHUB_PATH
119106
- name: Build libReactant
120-
if: ${{ matrix.libReactant == 'local' && matrix.os != 'macOS-latest'}}
107+
if: ${{ matrix.libReactant == 'local' && !startsWith(matrix.os, 'macOS-') }}
121108
id: build_libreactant
122109
run: |
123110
python -m pip install numpy
124111
julia --color=yes --project=deps -e 'using Pkg; Pkg.instantiate()'
125112
julia --color=yes --project=deps deps/build_local.jl
126113
cp LocalPreferences.toml test/
127114
- name: Build libReactant MacOS
128-
if: ${{ matrix.libReactant == 'local' && matrix.os == 'macOS-latest'}}
115+
if: ${{ matrix.libReactant == 'local' && !startsWith(matrix.os, 'macOS-') }}
129116
id: build_libreactant_mac
130117
run: |
131118
python -m pip install numpy

.github/workflows/downgrade.yml

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ concurrency:
2929
jobs:
3030
downgrade:
3131
# if: ${{ !contains(github.event.head_commit.message, '[skip tests]') && github.base_ref == github.event.repository.default_branch }}
32+
timeout-minutes: 90
3233
runs-on: ubuntu-latest
3334
strategy:
3435
fail-fast: false

0 commit comments

Comments
 (0)