From ac12477c1edff7f7e7d44053e4975631148a9360 Mon Sep 17 00:00:00 2001
From: maira-samtek <maira@samtek.io>
Date: Thu, 18 Jul 2024 17:31:56 -0400
Subject: [PATCH] fix(check): checked the arn split

---
 src/macpro-security-hub-sync.ts | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/macpro-security-hub-sync.ts b/src/macpro-security-hub-sync.ts
index 06efeb6..861558e 100644
--- a/src/macpro-security-hub-sync.ts
+++ b/src/macpro-security-hub-sync.ts
@@ -182,13 +182,21 @@ export class SecurityHubJiraSync {
     if (findingId.startsWith("arn:")) {
       // Extract region and account ID from the ARN
       const arnParts = findingId.split(":");
-      region = arnParts[3];
-      accountId = arnParts[4];
+      if (arnParts.length >= 5) {
+        region = arnParts[3];
+        accountId = arnParts[4];
+      } else {
+        return "Invalid URL";
+      }
     } else {
       // Extract region and account ID from the non-ARN format
       const parts = findingId.split("/");
-      region = parts[1];
-      accountId = parts[2];
+      if (parts.length >= 3) {
+        region = parts[1];
+        accountId = parts[2];
+      } else {
+        return "Invalid URL";
+      }
     }
 
     const baseUrl = `https://${region}.console.aws.amazon.com/securityhub/home?region=${region}`;