Skip to content

Commit f32c539

Browse files
committed
upgrade to graphql-java-13 and remove some deprecated usages
1 parent 06fc05b commit f32c539

File tree

4 files changed

+15
-28
lines changed

4 files changed

+15
-28
lines changed

build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ gradle.projectsEvaluated {
6363

6464
dependencies {
6565
compile 'javax.validation:validation-api:1.1.0.Final'
66-
compile 'com.graphql-java:graphql-java:12.0'
66+
compile 'com.graphql-java:graphql-java:13.0'
6767

6868
// OSGi
6969
compileOnly 'org.osgi:org.osgi.core:6.0.0'

src/test/java/graphql/annotations/connection/GraphQLEnhancedConnectionTest.java

+7-10
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,7 @@ public void ConnectionFieldDoesntReturnPaginatedData_tryToBuildSchema_getExcepti
134134
@Test
135135
public void validDatafetcher_queryForCursors_getValidCursors() throws Exception {
136136
//Arrange
137-
ExecutionInput executionInput = new ExecutionInput("{ objs(first:2) { edges { cursor } } }",
138-
null, "CONTEXT", null, new HashMap<>());
137+
ExecutionInput executionInput = ExecutionInput.newExecutionInput().query("{ objs(first:2) { edges { cursor } } }").build();
139138
//Act
140139
ExecutionResult result = graphQL.execute(executionInput);
141140
Map<String, Map<String, List<Map<String, Map<String, Object>>>>> data = result.getData();
@@ -149,8 +148,7 @@ public void validDatafetcher_queryForCursors_getValidCursors() throws Exception
149148
@Test
150149
public void fetchConnectionAsync() throws Exception {
151150
//Arrange
152-
ExecutionInput executionInput = new ExecutionInput("{ objsAsync(first:2) { edges { cursor } } }",
153-
null, "CONTEXT", null, new HashMap<>());
151+
ExecutionInput executionInput = ExecutionInput.newExecutionInput().query("{ objsAsync(first:2) { edges { cursor } } }").build();
154152
//Act
155153
ExecutionResult result = graphQL.execute(executionInput);
156154
Map<String, Map<String, List<Map<String, Map<String, Object>>>>> data = result.getData();
@@ -164,8 +162,9 @@ public void fetchConnectionAsync() throws Exception {
164162
@Test
165163
public void validDatafetcher_queryForValues_returnsValidValues() throws Exception {
166164
//Arrange
167-
ExecutionInput executionInput = new ExecutionInput("{ objs(first:2) { edges { cursor node { id, val } } } }",
168-
null, "CONTEXT", null, new HashMap<>());
165+
ExecutionInput executionInput = ExecutionInput.newExecutionInput().query("{ objs(first:2) { edges { cursor node { id, val } } } }")
166+
.context("CONTEXT").root(null).operationName(null).variables(new HashMap<>())
167+
.build();
169168

170169
//Act
171170
ExecutionResult result = graphQL.execute(executionInput);
@@ -181,8 +180,7 @@ public void validDatafetcher_queryForValues_returnsValidValues() throws Exceptio
181180
public void validDatafetcher_queryForHasPreviousPage_returnsFalse() throws Exception {
182181

183182
//Arrange
184-
ExecutionInput executionInput = new ExecutionInput("{ objs(first:2) { pageInfo { hasPreviousPage } } }",
185-
null, "CONTEXT", null, new HashMap<>());
183+
ExecutionInput executionInput = ExecutionInput.newExecutionInput().query("{ objs(first:2) { pageInfo { hasPreviousPage } } }").build();
186184

187185
//Act
188186
ExecutionResult result = graphQL.execute(executionInput);
@@ -196,8 +194,7 @@ public void validDatafetcher_queryForHasPreviousPage_returnsFalse() throws Excep
196194
public void validDatafetcher_queryForHasNextPage_returnsTrue() throws Exception {
197195

198196
//Arrange
199-
ExecutionInput executionInput = new ExecutionInput("{ objs(first:2) { pageInfo { hasNextPage } } }",
200-
null, "CONTEXT", null, new HashMap<>());
197+
ExecutionInput executionInput = ExecutionInput.newExecutionInput().query("{ objs(first:2) { pageInfo { hasNextPage } } }").build();
201198

202199
//Act
203200
ExecutionResult result = graphQL.execute(executionInput);

src/test/java/graphql/annotations/directives/DirectiveWirerTest.java

+5-15
Original file line numberDiff line numberDiff line change
@@ -188,16 +188,11 @@ public void wireGraphQLArgument_invalidLocations_exceptionIsThrown() throws Exce
188188
// GraphQLInterfaceType
189189

190190
@Test
191-
public void wireGraphQLInterfaceType_validLocations_correctMethodIsCalled() throws Exception {
191+
public void wireGraphQLInterfaceType_validLocations_correctMethodIsCalled() {
192192
// Arrange
193193
AnnotationsDirectiveWiring upperWiring = mock(AnnotationsDirectiveWiring.class);
194194

195-
GraphQLInterfaceType directiveContainer = GraphQLInterfaceType.newInterface().name("asdf").typeResolver(new TypeResolver() {
196-
@Override
197-
public GraphQLObjectType getType(TypeResolutionEnvironment env) {
198-
return null;
199-
}
200-
}).build();
195+
GraphQLInterfaceType directiveContainer = GraphQLInterfaceType.newInterface().name("asdf").build();
201196

202197
AnnotationsWiringEnvironmentImpl upperCaseEnv = new AnnotationsWiringEnvironmentImpl(directiveContainer,
203198
directiveContainer.getDirective("upperCase"), parentName, builder);
@@ -221,12 +216,7 @@ public void wireGraphQLInterfaceType_invalidLocations_exceptionIsThrown() throws
221216
// Arrange
222217
AnnotationsDirectiveWiring upperWiring = mock(AnnotationsDirectiveWiring.class);
223218

224-
GraphQLInterfaceType directiveContainer = GraphQLInterfaceType.newInterface().name("asdf").typeResolver(new TypeResolver() {
225-
@Override
226-
public GraphQLObjectType getType(TypeResolutionEnvironment env) {
227-
return null;
228-
}
229-
}).build();
219+
GraphQLInterfaceType directiveContainer = GraphQLInterfaceType.newInterface().name("asdf").build();
230220

231221
AnnotationsWiringEnvironmentImpl upperCaseEnv = new AnnotationsWiringEnvironmentImpl(directiveContainer,
232222
directiveContainer.getDirective("upperCase"), parentName, builder);
@@ -249,7 +239,7 @@ public void wireGraphQLUnionType_validLocations_correctMethodIsCalled() throws E
249239
AnnotationsDirectiveWiring upperWiring = mock(AnnotationsDirectiveWiring.class);
250240

251241
GraphQLUnionType directiveContainer = GraphQLUnionType.newUnionType().name("asdf")
252-
.possibleType(GraphQLObjectType.newObject().name("Asdfaaaa").build()).typeResolver(env -> null).build();
242+
.possibleType(GraphQLObjectType.newObject().name("Asdfaaaa").build()).build();
253243

254244
AnnotationsWiringEnvironmentImpl upperCaseEnv = new AnnotationsWiringEnvironmentImpl(
255245
directiveContainer, directiveContainer.getDirective("upperCase"), parentName, builder);
@@ -274,7 +264,7 @@ public void wireGraphQLUnionType_invalidLocations_exceptionIsThrown() throws Exc
274264
AnnotationsDirectiveWiring upperWiring = mock(AnnotationsDirectiveWiring.class);
275265

276266
GraphQLUnionType directiveContainer = GraphQLUnionType.newUnionType().name("asdf")
277-
.possibleType(GraphQLObjectType.newObject().name("Asdfaaaa").build()).typeResolver(env -> null).build();
267+
.possibleType(GraphQLObjectType.newObject().name("Asdfaaaa").build()).build();
278268

279269

280270
AnnotationsWiringEnvironmentImpl upperCaseEnv = new AnnotationsWiringEnvironmentImpl(

src/test/java/graphql/annotations/processor/typeFunctions/DefaultTypeFunctionTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@ public void enumeration() {
5959
List<GraphQLEnumValueDefinition> values = ((GraphQLEnumType) enumeration).getValues();
6060
assertEquals(values.stream().
6161
map(GraphQLEnumValueDefinition::getName).collect(Collectors.toList()),
62-
Arrays.asList("B", "someA"));
62+
Arrays.asList("someA", "B"));
6363
assertEquals(values.stream().
6464
map(GraphQLEnumValueDefinition::getDescription).collect(Collectors.toList()),
65-
Arrays.asList("B", "a"));
65+
Arrays.asList("a", "B"));
6666

6767
}
6868

0 commit comments

Comments
 (0)