Merge pull request #134 from Gillespie59/development

0.1.0

Author: EmmanuelDemey

index.js

@@ -8,6 +8,7 @@
                   'ng_controller_as_route': require('./rules/ng_controller_as_route'),
                   'ng_controller_as_vm': require('./rules/ng_controller_as_vm'),
                   'ng_controller_name': require('./rules/ng_controller_name'),
+                  'ng_deferred': require('./rules/ng_deferred'),
                   'ng_definedundefined': require('./rules/ng_definedundefined'),
                   'ng_di': require('./rules/ng_di'),
                   'ng_directive_name': require('./rules/ng_directive_name'),
@@ -44,6 +45,7 @@
                   'ng_controller_as_route': 2,
                   'ng_controller_as_vm': [2, 'vm'],
                   'ng_controller_name': [2, /[A-Z].*Controller$/],
+                  'ng_deferred': 0,
                   'ng_definedundefined': 2,
                   'ng_di': [2, 'function'],
                   'ng_directive_name': 0,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-angular",
-  "version": "0.0.15",
+  "version": "0.1.0",
   "description": "ESLint rules for AngularJS projects",
   "main": "index.js",
   "repository": {

rules/ng_deferred.js

@@ -0,0 +1,17 @@
+module.exports = function(context) {
+
+    'use strict';
+
+    return {
+
+        'MemberExpression': function(node) {
+            if(node.object.type === 'Identifier' && node.object.name === '$q'){
+                if(node.property.type === 'Identifier' && node.property.name === 'deferred'){
+                    context.report(node, 'You should not create a new promise with this syntax. Use the $q(function(resolve, reject){}) syntax.', {});
+                }
+
+            }
+        }
+    };
+
+};

test/ng_deferred.js

@@ -0,0 +1,20 @@
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+var eslint = require('../node_modules/eslint/lib/eslint'),
+    ESLintTester = require('eslint-tester');
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+var eslintTester = new ESLintTester(eslint);
+eslintTester.addRuleTest('rules/ng_deferred', {
+    valid: [
+        '$qs(function(){});'
+    ],
+    invalid: [
+        { code: 'var deferred = $q.deferred;', errors: [{ message: 'You should not create a new promise with this syntax. Use the $q(function(resolve, reject){}) syntax.'}] }
+    ]
+});