Skip to content

Commit c393173

Browse files
committed
Issue #123 angular.isBoolean does not exist, remove ng_typecheck_boolean
1 parent 939efb6 commit c393173

File tree

3 files changed

+1
-40
lines changed

3 files changed

+1
-40
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ We provide also three samples :
7373
| 'ng_service_name': 2 | All your services should have a name starting with the parameter you can define in your config object. The second parameter can be a Regexp wrapped in quotes. You can not prefix your services by "$" (reserved keyword for AngularJS services) ("ng_service_name": [2, "ng"]) [Y125](https://github.com/johnpapa/angular-styleguide#style-y125) |
7474
| 'ng_timeout_service': 2 | Instead of the default setTimeout function, you should use the AngularJS wrapper service $timeout [Y181](https://github.com/johnpapa/angular-styleguide#style-y181) |
7575
| 'ng_typecheck_array': 2 | You should use the angular.isArray method instead of the default JavaScript implementation (typeof [] === "[object Array]"). |
76-
| 'ng_typecheck_boolean': 2 | You should use the angular.isBoolean method instead of the default JavaScript implementation (typeof true === "[object Boolean]"). |
7776
| 'ng_typecheck_date': 2 | You should use the angular.isDate method instead of the default JavaScript implementation (typeof new Date() === "[object Date]"). |
7877
| 'ng_typecheck_function': 2 | You should use the angular.isFunction method instead of the default JavaScript implementation (typeof function(){} ==="[object Function]"). |
7978
| 'ng_typecheck_number': 2 | You should use the angular.isNumber method instead of the default JavaScript implementation (typeof 3 === "[object Number]"). |

index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
'ng_service_name': require('./rules/ng_service_name'),
3131
'ng_timeout_service': require('./rules/ng_timeout_service'),
3232
'ng_typecheck_array': require('./rules/ng_typecheck_array'),
33-
'ng_typecheck_boolean': require('./rules/ng_typecheck_boolean'),
3433
'ng_typecheck_date': require('./rules/ng_typecheck_date'),
3534
'ng_typecheck_function': require('./rules/ng_typecheck_function'),
3635
'ng_typecheck_number': require('./rules/ng_typecheck_number'),
@@ -67,7 +66,6 @@
6766
'ng_service_name': 0,
6867
'ng_timeout_service': 2,
6968
'ng_typecheck_array': 2,
70-
'ng_typecheck_boolean': 2,
7169
'ng_typecheck_date': 2,
7270
'ng_typecheck_function': 2,
7371
'ng_typecheck_number': 2,
@@ -77,4 +75,4 @@
7775
'ng_window_service': 2
7876
}
7977
};
80-
})();
78+
})();

test/ng_typecheck_boolean.js

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)