Merge branch 'development' into issue-229/function-type-rule-does-not-recognize-inline-named-functions-properly

Author: tilmanschweitzer

rules/on-watch.js

@@ -46,10 +46,6 @@ module.exports = function(context) {
      * argument of the string '$destroy'.
      */
     function isFirstArgDestroy(node) {
-        if (node.type !== 'CallExpression') {
-            return false;
-        }
-
         var args = node.arguments;
 
         return (args.length >= 1 &&

test/on-watch.js

@@ -30,7 +30,13 @@ eslintTester.run('on-watch', rule, {
         'scope.$on()',
         'scope.$watch()',
         '$scope.$on()',
-        '$scope.$watch()'
+        '$scope.$watch()',
+
+        // false positive check
+        '$on()',
+
+        // uncovered edgecase
+        '$scope["$on"]()'
 
     ],
     invalid: [